Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4024)

Unified Diff: chrome/browser/chromeos/cros/cros_network_functions.cc

Issue 11361211: chromeos: Remove unused CrosAddIPConfig/CrosRemoveIPConfig functions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/cros/cros_network_functions.cc
diff --git a/chrome/browser/chromeos/cros/cros_network_functions.cc b/chrome/browser/chromeos/cros/cros_network_functions.cc
index aff8e27dca2cfb7d19569a67e4210930b4f5388a..60d129ef80dde74ab8861616d9ced54c4cfe8891 100644
--- a/chrome/browser/chromeos/cros/cros_network_functions.cc
+++ b/chrome/browser/chromeos/cros/cros_network_functions.cc
@@ -692,49 +692,6 @@ bool CrosListIPConfigs(const std::string& device_path,
return true;
}
-bool CrosAddIPConfig(const std::string& device_path, IPConfigType type) {
- std::string type_str;
- switch (type) {
- case IPCONFIG_TYPE_IPV4:
- type_str = flimflam::kTypeIPv4;
- break;
- case IPCONFIG_TYPE_IPV6:
- type_str = flimflam::kTypeIPv6;
- break;
- case IPCONFIG_TYPE_DHCP:
- type_str = flimflam::kTypeDHCP;
- break;
- case IPCONFIG_TYPE_BOOTP:
- type_str = flimflam::kTypeBOOTP;
- break;
- case IPCONFIG_TYPE_ZEROCONF:
- type_str = flimflam::kTypeZeroConf;
- break;
- case IPCONFIG_TYPE_DHCP6:
- type_str = flimflam::kTypeDHCP6;
- break;
- case IPCONFIG_TYPE_PPP:
- type_str = flimflam::kTypePPP;
- break;
- default:
- return false;
- };
- const dbus::ObjectPath result =
- DBusThreadManager::Get()->GetShillDeviceClient()->
- CallAddIPConfigAndBlock(dbus::ObjectPath(device_path), type_str);
- if (result.value().empty()) {
- LOG(ERROR) << "Add IPConfig failed for device path " << device_path
- << " and type " << type_str;
- return false;
- }
- return true;
-}
-
-bool CrosRemoveIPConfig(const std::string& ipconfig_path) {
- return DBusThreadManager::Get()->GetShillIPConfigClient()->
- CallRemoveAndBlock(dbus::ObjectPath(ipconfig_path));
-}
-
void CrosRequestIPConfigRefresh(const std::string& ipconfig_path) {
DBusThreadManager::Get()->GetShillIPConfigClient()->Refresh(
dbus::ObjectPath(ipconfig_path),
« no previous file with comments | « chrome/browser/chromeos/cros/cros_network_functions.h ('k') | chrome/browser/chromeos/cros/cros_network_functions_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698