Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 11361046: Remove TabContents from TabModalConfirmDialog. (Closed)

Created:
8 years, 1 month ago by Avi (use Gerrit)
Modified:
8 years, 1 month ago
Reviewers:
Nico, Elliot Glaysher, sky
CC:
chromium-reviews, jam, darin-cc_chromium.org, tfarina, rdsmith+dwatch_chromium.org, stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Remove TabContents from TabModalConfirmDialog. BUG=107201 TEST=no visible change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165723

Patch Set 1 #

Patch Set 2 : missing include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -44 lines) Patch
M chrome/browser/download/download_danger_prompt.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugins/plugin_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tab_modal_confirm_dialog_mac.h View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/tab_modal_confirm_dialog_mac.mm View 6 chunks +7 lines, -10 lines 0 comments Download
M chrome/browser/ui/gtk/tab_modal_confirm_dialog_gtk.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/tab_modal_confirm_dialog_gtk.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/ui/tab_modal_confirm_dialog.h View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/tab_modal_confirm_dialog_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/external_tab_container_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tab_modal_confirm_dialog_views.h View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/ui/views/tab_modal_confirm_dialog_views.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/tab_modal_confirm_dialog_webui.h View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/tab_modal_confirm_dialog_webui.cc View 1 3 chunks +7 lines, -9 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
Avi (use Gerrit)
thakis/erg/sky: platforms
8 years, 1 month ago (2012-11-01 21:33:52 UTC) #1
Nico
first 5 files lgtm (the rest is gtk / views afaict)
8 years, 1 month ago (2012-11-01 21:41:47 UTC) #2
sky
LGTM
8 years, 1 month ago (2012-11-01 22:28:56 UTC) #3
Elliot Glaysher
gtk lgtm
8 years, 1 month ago (2012-11-01 22:43:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/11361046/1
8 years, 1 month ago (2012-11-02 03:01:50 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
8 years, 1 month ago (2012-11-02 07:43:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/11361046/1
8 years, 1 month ago (2012-11-02 13:10:34 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
8 years, 1 month ago (2012-11-02 13:28:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/11361046/13001
8 years, 1 month ago (2012-11-02 14:11:11 UTC) #9
commit-bot: I haz the power
Retried try job too often for step(s) content_browsertests
8 years, 1 month ago (2012-11-02 16:16:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/11361046/13001
8 years, 1 month ago (2012-11-02 16:26:48 UTC) #11
commit-bot: I haz the power
Retried try job too often for step(s) content_browsertests
8 years, 1 month ago (2012-11-02 17:37:39 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/11361046/13001
8 years, 1 month ago (2012-11-02 17:56:44 UTC) #13
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
8 years, 1 month ago (2012-11-02 18:03:05 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/11361046/13001
8 years, 1 month ago (2012-11-02 18:27:02 UTC) #15
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
8 years, 1 month ago (2012-11-02 18:43:39 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/11361046/13001
8 years, 1 month ago (2012-11-02 18:46:23 UTC) #17
commit-bot: I haz the power
8 years, 1 month ago (2012-11-02 19:07:21 UTC) #18
Change committed as 165723

Powered by Google App Engine
This is Rietveld 408576698