8 years, 2 months ago
(2012-11-01 12:46:07 UTC)
#1
yurys
http://codereview.chromium.org/11361034/diff/2004/content/browser/debugger/devtools_http_handler_impl.cc File content/browser/debugger/devtools_http_handler_impl.cc (right): http://codereview.chromium.org/11361034/diff/2004/content/browser/debugger/devtools_http_handler_impl.cc#newcode117 content/browser/debugger/devtools_http_handler_impl.cc:117: base::JSONWriter::WriteWithOptions(&message, Can you provide a method in WebKit API ...
8 years, 2 months ago
(2012-11-01 15:37:11 UTC)
#2
http://codereview.chromium.org/11361034/diff/2004/content/browser/debugger/de...
File content/browser/debugger/devtools_http_handler_impl.cc (right):
http://codereview.chromium.org/11361034/diff/2004/content/browser/debugger/de...
content/browser/debugger/devtools_http_handler_impl.cc:117:
base::JSONWriter::WriteWithOptions(&message,
Can you provide a method in WebKit API that would create the message to make the
dependency clear? I don't like the idea of sending protocol message from the
remote debugger server which is expected to provide a transport for the
inspector protocol. Ideally there should be a notification from the embedder
that it is going to shut down and the inspector agent should listen to it and
send the message over the protocol. WDYT?
pfeldman
http://codereview.chromium.org/11361034/diff/2004/content/browser/debugger/devtools_http_handler_impl.cc File content/browser/debugger/devtools_http_handler_impl.cc (right): http://codereview.chromium.org/11361034/diff/2004/content/browser/debugger/devtools_http_handler_impl.cc#newcode117 content/browser/debugger/devtools_http_handler_impl.cc:117: base::JSONWriter::WriteWithOptions(&message, We can't delegate it to the dying renderer, ...
8 years, 2 months ago
(2012-11-01 16:24:48 UTC)
#3
http://codereview.chromium.org/11361034/diff/2004/content/browser/debugger/devtools_http_handler_impl.cc File content/browser/debugger/devtools_http_handler_impl.cc (right): http://codereview.chromium.org/11361034/diff/2004/content/browser/debugger/devtools_http_handler_impl.cc#newcode117 content/browser/debugger/devtools_http_handler_impl.cc:117: base::JSONWriter::WriteWithOptions(&message, On 2012/11/01 15:37:11, Yury Semikhatsky wrote: > Can ...
8 years, 2 months ago
(2012-11-01 16:54:32 UTC)
#4
http://codereview.chromium.org/11361034/diff/2004/content/browser/debugger/de...
File content/browser/debugger/devtools_http_handler_impl.cc (right):
http://codereview.chromium.org/11361034/diff/2004/content/browser/debugger/de...
content/browser/debugger/devtools_http_handler_impl.cc:117:
base::JSONWriter::WriteWithOptions(&message,
On 2012/11/01 15:37:11, Yury Semikhatsky wrote:
> Can you provide a method in WebKit API that would create the message to make
the
> dependency clear? I don't like the idea of sending protocol message from the
> remote debugger server which is expected to provide a transport for the
> inspector protocol. Ideally there should be a notification from the embedder
> that it is going to shut down and the inspector agent should listen to it and
> send the message over the protocol. WDYT?
Done.
yurys
lgtm http://codereview.chromium.org/11361034/diff/12002/content/browser/debugger/devtools_http_handler_impl.cc File content/browser/debugger/devtools_http_handler_impl.cc (right): http://codereview.chromium.org/11361034/diff/12002/content/browser/debugger/devtools_http_handler_impl.cc#newcode113 content/browser/debugger/devtools_http_handler_impl.cc:113: WebKit::WebDevToolsAgent::inspectorDetachedEvent( You need to make sure that WebKit ...
8 years, 2 months ago
(2012-11-02 06:59:58 UTC)
#5
Issue 11361034: DevTools: [remote debugging] emit Inspector.detached protocol message upon connectin termination.
(Closed)
Created 8 years, 2 months ago by pfeldman
Modified 7 years, 9 months ago
Reviewers: yurys
Base URL: svn://svn.chromium.org/chrome/trunk/src
Comments: 4