DevTools: [remote debugging] emit Inspector.detached protocol message upon connectin termination.

DevTools: [remote debugging] emit Inspector.detached protocol message upon connectin termination.

BUG=129539

[yurys, 2012-11-01 15:37:11]

http://codereview.chromium.org/11361034/diff/2004/content/browser/debugger/de...
File content/browser/debugger/devtools_http_handler_impl.cc (right):

http://codereview.chromium.org/11361034/diff/2004/content/browser/debugger/de...
content/browser/debugger/devtools_http_handler_impl.cc:117:
base::JSONWriter::WriteWithOptions(&message,
Can you provide a method in WebKit API that would create the message to make the
dependency clear? I don't like the idea of sending protocol message from the
remote debugger server which is expected to provide a transport for the
inspector protocol. Ideally there should be a notification from the embedder
that it is going to shut down and the inspector agent should listen to it and
send the message over the protocol. WDYT?

[pfeldman, 2012-11-01 16:24:48]

http://codereview.chromium.org/11361034/diff/2004/content/browser/debugger/de...
File content/browser/debugger/devtools_http_handler_impl.cc (right):

http://codereview.chromium.org/11361034/diff/2004/content/browser/debugger/de...
content/browser/debugger/devtools_http_handler_impl.cc:117:
base::JSONWriter::WriteWithOptions(&message,
We can't delegate it to the dying renderer, but I share your concern. I'll
either add the message to the WebKit API or introduce a new domain.

[pfeldman, 2012-11-01 16:54:32]

http://codereview.chromium.org/11361034/diff/2004/content/browser/debugger/de...
File content/browser/debugger/devtools_http_handler_impl.cc (right):

http://codereview.chromium.org/11361034/diff/2004/content/browser/debugger/de...
content/browser/debugger/devtools_http_handler_impl.cc:117:
base::JSONWriter::WriteWithOptions(&message,
On 2012/11/01 15:37:11, Yury Semikhatsky wrote:
> Can you provide a method in WebKit API that would create the message to make
the
> dependency clear? I don't like the idea of sending protocol message from the
> remote debugger server which is expected to provide a transport for the
> inspector protocol. Ideally there should be a notification from the embedder
> that it is going to shut down and the inspector agent should listen to it and
> send the message over the protocol. WDYT?

Done.

[yurys, 2012-11-02 06:59:58]

lgtm

http://codereview.chromium.org/11361034/diff/12002/content/browser/debugger/d...
File content/browser/debugger/devtools_http_handler_impl.cc (right):

http://codereview.chromium.org/11361034/diff/12002/content/browser/debugger/d...
content/browser/debugger/devtools_http_handler_impl.cc:113:
WebKit::WebDevToolsAgent::inspectorDetachedEvent(
You need to make sure that WebKit is is initialized at this point to avoid
crashes like the one we had in the render process.