Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5691)

Unified Diff: chrome/browser/ui/zoom/zoom_controller.cc

Issue 11359205: [zoom bubble] First part of speculative fix for zoom bubble crashes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/zoom/OWNERS ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/zoom/zoom_controller.cc
diff --git a/chrome/browser/ui/zoom/zoom_controller.cc b/chrome/browser/ui/zoom/zoom_controller.cc
index 6b0de350b29e627cbc81545a3cd5e2cd61ecdbe6..d0363a7ae76a9d5fc1486e19e04a1823eeb947ca 100644
--- a/chrome/browser/ui/zoom/zoom_controller.cc
+++ b/chrome/browser/ui/zoom/zoom_controller.cc
@@ -79,6 +79,8 @@ void ZoomController::UpdateState(const std::string& host) {
if (host.empty())
return;
+ CHECK(web_contents()); // http://crbug.com/144879
+
// Use the active navigation entry's URL instead of the WebContents' so
// virtual URLs work (e.g. chrome://settings). http://crbug.com/153950
content::NavigationEntry* active_entry =
« no previous file with comments | « chrome/browser/ui/zoom/OWNERS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698