Chromium Code Reviews
Help | Chromium Project | Sign in
(27)

Issue 11359205: [zoom bubble] First part of speculative fix for zoom bubble crashes. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 9 months ago by Dan Beam
Modified:
2 years, 9 months ago
Reviewers:
Avi
CC:
chromium-reviews, Kyle Horimoto
Visibility:
Public.

Description

[zoom bubble] First part of speculative fix for zoom bubble crashes. R=avi@chromium.org BUG=144879 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=168086

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
A chrome/browser/ui/zoom/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/zoom/zoom_controller.cc View 1 chunk +2 lines, -0 lines 0 comments Download
Trybot results:
Project "None" does not have a commit queue.

Messages

Total messages: 7 (0 generated)
Dan Beam
I still don't really think this makes a ton of sense to commit on trunk ...
2 years, 9 months ago (2012-11-14 06:06:38 UTC) #1
Dan Beam
https://chromiumcodereview.appspot.com/11359205/diff/1/chrome/browser/ui/zoom/OWNERS File chrome/browser/ui/zoom/OWNERS (right): https://chromiumcodereview.appspot.com/11359205/diff/1/chrome/browser/ui/zoom/OWNERS#newcode1 chrome/browser/ui/zoom/OWNERS:1: dbeam@chromium.org I created this so people know who to ...
2 years, 9 months ago (2012-11-14 06:07:23 UTC) #2
Avi
Uh, OK. I thought we were suspecting a bogus delegate. I don't believe this is ...
2 years, 9 months ago (2012-11-14 17:20:34 UTC) #3
Avi
I'm still waiting for a plausible explanation of how this being null would crash in ...
2 years, 9 months ago (2012-11-14 17:22:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/11359205/1
2 years, 9 months ago (2012-11-14 23:59:00 UTC) #5
commit-bot: I haz the power
Retried try job too often for step(s) sync_integration_tests
2 years, 9 months ago (2012-11-15 07:34:08 UTC) #6
commit-bot: I haz the power
2 years, 9 months ago (2012-11-15 08:25:08 UTC) #7
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld c33a7a4