Chromium Code Reviews
Help | Chromium Project | Sign in
(1058)

Issue 11359205: [zoom bubble] First part of speculative fix for zoom bubble crashes. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by Dan Beam
Modified:
1 year, 5 months ago
Reviewers:
Avi
CC:
chromium-reviews_chromium.org, Kyle Horimoto
Visibility:
Public.

Description

[zoom bubble] First part of speculative fix for zoom bubble crashes.

R=avi@chromium.org
BUG=144879
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=168086

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Lint Patch
A chrome/browser/ui/zoom/OWNERS View 1 chunk +2 lines, -0 lines 0 comments ? errors Download
M chrome/browser/ui/zoom/zoom_controller.cc View 1 chunk +2 lines, -0 lines 0 comments 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 7
Dan Beam
I still don't really think this makes a ton of sense to commit on trunk ...
1 year, 5 months ago #1
Dan Beam
https://chromiumcodereview.appspot.com/11359205/diff/1/chrome/browser/ui/zoom/OWNERS File chrome/browser/ui/zoom/OWNERS (right): https://chromiumcodereview.appspot.com/11359205/diff/1/chrome/browser/ui/zoom/OWNERS#newcode1 chrome/browser/ui/zoom/OWNERS:1: dbeam@chromium.org I created this so people know who to ...
1 year, 5 months ago #2
Avi
Uh, OK. I thought we were suspecting a bogus delegate. I don't believe this is ...
1 year, 5 months ago #3
Avi
I'm still waiting for a plausible explanation of how this being null would crash in ...
1 year, 5 months ago #4
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/11359205/1
1 year, 5 months ago #5
I haz the power (commit-bot)
Retried try job too often for step(s) sync_integration_tests
1 year, 5 months ago #6
I haz the power (commit-bot)
1 year, 5 months ago #7
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1275:d14800f88434