chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc - Issue 11359201: Remove TabContents from TabStripModelObserver::TabReplacedAt.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc

Issue 11359201: Remove TabContents from TabStripModelObserver::TabReplacedAt. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc

diff --git a/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc b/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc

index 604d0ab79153beef707363eaee706fdc930dce39..2bdebb0c996c202b4c69a5de867df2cf22134a30 100644

--- a/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc

+++ b/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc

@@ -411,10 +411,10 @@ void BrowserTabStripController::TabChangedAt(WebContents* contents,

}

void BrowserTabStripController::TabReplacedAt(TabStripModel* tab_strip_model,

- TabContents* old_contents,

- TabContents* new_contents,

+ WebContents* old_contents,

+ WebContents* new_contents,

int model_index) {

- SetTabDataAt(new_contents->web_contents(), model_index);

+ SetTabDataAt(new_contents, model_index);

}

void BrowserTabStripController::TabPinnedStateChanged(WebContents* contents,

« no previous file with comments | « chrome/browser/ui/views/tabs/browser_tab_strip_controller.h ('k') | no next file » | no next file with comments »