chrome/browser/ui/tabs/tab_strip_model.cc - Issue 11359201: Remove TabContents from TabStripModelObserver::TabReplacedAt.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/tabs/tab_strip_model.cc

Issue 11359201: Remove TabContents from TabStripModelObserver::TabReplacedAt. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/tabs/tab_strip_model.cc

diff --git a/chrome/browser/ui/tabs/tab_strip_model.cc b/chrome/browser/ui/tabs/tab_strip_model.cc

index 1d5f4a1d47be88c58175c6effa53ab5b63dd5e4e..61e072a46c7ff8a3700853d2aa57821f9a71d4a6 100644

--- a/chrome/browser/ui/tabs/tab_strip_model.cc

+++ b/chrome/browser/ui/tabs/tab_strip_model.cc

@@ -159,7 +159,10 @@ TabContents* TabStripModel::ReplaceTabContentsAt(int index,

contents_data_[index]->contents = new_contents->web_contents();

FOR_EACH_OBSERVER(TabStripModelObserver, observers_,

- TabReplacedAt(this, old_contents, new_contents, index));

+ TabReplacedAt(this,

+ old_contents->web_contents(),

+ new_contents->web_contents(),

+ index));

// When the active tab contents is replaced send out a selection notification

// too. We do this as nearly all observers need to treat a replacement of the