chrome/browser/extensions/browser_event_router.cc - Issue 11359201: Remove TabContents from TabStripModelObserver::TabReplacedAt.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/browser_event_router.cc

Issue 11359201: Remove TabContents from TabStripModelObserver::TabReplacedAt. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/browser_event_router.cc

diff --git a/chrome/browser/extensions/browser_event_router.cc b/chrome/browser/extensions/browser_event_router.cc

index c39a39ed920ba7859361154d753b74661dbe8ea1..861cfcdcf72bff5993feed6784a0bf73e338da27 100644

--- a/chrome/browser/extensions/browser_event_router.cc

+++ b/chrome/browser/extensions/browser_event_router.cc

@@ -475,13 +475,11 @@ void BrowserEventRouter::TabChangedAt(WebContents* contents,

}

void BrowserEventRouter::TabReplacedAt(TabStripModel* tab_strip_model,

- TabContents* old_contents,

- TabContents* new_contents,

+ WebContents* old_contents,

+ WebContents* new_contents,

int index) {

- TabClosingAt(tab_strip_model, old_contents->web_contents(), index);

- TabInsertedAt(new_contents->web_contents(),

- index,

- tab_strip_model->active_index() == index);

+ TabClosingAt(tab_strip_model, old_contents, index);

+ TabInsertedAt(new_contents, index, tab_strip_model->active_index() == index);

}

void BrowserEventRouter::TabPinnedStateChanged(WebContents* contents,