Issue 11358214: Remove 'type' and 'arguments' properties from Error object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11358214: Remove 'type' and 'arguments' properties from Error object. (Closed)

Created:
8 years, 1 month ago by Yang

Modified:
8 years, 1 month ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Remove 'type' and 'arguments' properties from Error object. R=svenpanne@chromium.org BUG=v8:2397 Committed: https://code.google.com/p/v8/source/detail?r=12956

Patch Set 1 #

Total comments: 2

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+58 lines, -54 lines)			Patch
M	src/messages.js	View	3 chunks	+0 lines, -5 lines	1 comment	Download
M	test/cctest/test-parsing.cc	View	4 chunks	+35 lines, -10 lines	1 comment	Download
M	test/mjsunit/array-reduce.js	View	6 chunks	+8 lines, -8 lines	0 comments	Download
M	test/mjsunit/error-constructors.js	View	3 chunks	+1 line, -14 lines	0 comments	Download
M	test/mjsunit/function-call.js	View	9 chunks	+13 lines, -16 lines	0 comments	Download
M	test/mjsunit/regress/regress-1980.js	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Yang

PTAL. Most of the change are tests that relied on Error.type.

8 years, 1 month ago (2012-11-13 15:16:17 UTC) #1

Sven Panne

8 years, 1 month ago (2012-11-14 08:40:35 UTC) #2

LGTM with nits

http://codereview.chromium.org/11358214/diff/1/src/messages.js
File src/messages.js (right):

http://codereview.chromium.org/11358214/diff/1/src/messages.js#newcode258
src/messages.js:258: var e = new constructor(FormatMessage(type, args));
Just drop the "var e =", it's cleaner... ;-)

http://codereview.chromium.org/11358214/diff/1/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):

http://codereview.chromium.org/11358214/diff/1/test/cctest/test-parsing.cc#ne...
test/cctest/test-parsing.cc:1095: i::Handle<i::String> message_string;
Remove this line, merging it with the initialization below. In general, we
should avoid declaring any uninitialized variable. (Yes, I know, this one is
initialized via it's default constructor, but in a way it is still
uninitialized.)

Expand Messages | Collapse Messages