Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 11358159: Split ExtensionWebRequestApiTest.PostData into two (Closed)

Created:
8 years, 1 month ago by vabr (Chromium)
Modified:
8 years, 1 month ago
Reviewers:
Matt Perry
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org, battre
Visibility:
Public.

Description

Split ExtensionWebRequestApiTest.PostData into two On some debug trybots the original PostData test takes too long and hits the 45s time limit. This splits it into two tests. BUG=152859 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166907

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -20 lines) Patch
M chrome/browser/extensions/api/web_request/web_request_apitest.cc View 1 chunk +11 lines, -2 lines 0 comments Download
D chrome/test/data/extensions/api_test/webrequest/test_post.html View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/test/data/extensions/api_test/webrequest/test_post.js View 2 chunks +2 lines, -11 lines 0 comments Download
A + chrome/test/data/extensions/api_test/webrequest/test_post1.html View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/webrequest/test_post1.js View 1 chunk +11 lines, -0 lines 0 comments Download
A + chrome/test/data/extensions/api_test/webrequest/test_post2.html View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/webrequest/test_post2.js View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
vabr (Chromium)
Hi Matt, Could you please review this? Thanks, Vaclav
8 years, 1 month ago (2012-11-08 14:09:39 UTC) #1
Matt Perry
lgtm
8 years, 1 month ago (2012-11-08 20:24:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vabr@chromium.org/11358159/1
8 years, 1 month ago (2012-11-09 09:14:33 UTC) #3
commit-bot: I haz the power
Retried try job too often for step(s) browser_tests
8 years, 1 month ago (2012-11-09 11:24:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vabr@chromium.org/11358159/1
8 years, 1 month ago (2012-11-09 14:13:09 UTC) #5
commit-bot: I haz the power
8 years, 1 month ago (2012-11-09 14:13:45 UTC) #6
Change committed as 166907

Powered by Google App Engine
This is Rietveld 408576698