Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 11358153: Update libmtp from pre 1.1.4 git to 1.1.5 release. (Closed)

Created:
8 years, 1 month ago by Lei Zhang
Modified:
8 years, 1 month ago
CC:
chromium-reviews
Visibility:
Public.

Description

Update libmtp from pre 1.1.4 git to 1.1.5 release. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=167447

Patch Set 1 : #

Total comments: 2

Patch Set 2 : disable mptz #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2412 lines, -741 lines) Patch
M README View 4 chunks +27 lines, -10 lines 0 comments Download
M aclocal.m4 View 5 chunks +6 lines, -8 lines 0 comments Download
M config.h View 1 3 chunks +4 lines, -4 lines 2 comments Download
M configure View 29 chunks +38 lines, -43 lines 0 comments Download
M configure.ac View 2 chunks +2 lines, -1 line 0 comments Download
M examples/albumart.c View 1 chunk +1 line, -1 line 0 comments Download
M examples/albums.c View 1 chunk +1 line, -1 line 0 comments Download
M examples/detect.c View 1 chunk +1 line, -1 line 0 comments Download
M examples/filetree.c View 1 chunk +1 line, -1 line 0 comments Download
M ltmain.sh View 5 chunks +13 lines, -19 lines 0 comments Download
M m4/libtool.m4 View 9 chunks +9 lines, -24 lines 0 comments Download
M patches/00_disable_playlist.patch View 4 chunks +14 lines, -13 lines 0 comments Download
M patches/08_add_licenses.patch View 1 chunk +0 lines, -27 lines 0 comments Download
M patches/11_add_gyp_file_and_generated_headers.patch View 1 8 chunks +11 lines, -8 lines 0 comments Download
D patches/13_cherrypick_15d18e31.patch View 1 chunk +0 lines, -351 lines 0 comments Download
M src/Makefile.am View 2 chunks +6 lines, -2 lines 0 comments Download
M src/Makefile.in View 6 chunks +22 lines, -10 lines 0 comments Download
D src/gphoto2-sync.sh View 1 chunk +0 lines, -42 lines 0 comments Download
M src/libmtp.h View 4 chunks +6 lines, -3 lines 0 comments Download
M src/libmtp.c View 8 chunks +58 lines, -8 lines 0 comments Download
M src/libmtp.sym View 1 chunk +2 lines, -0 lines 0 comments Download
M src/libmtp.h.in View 4 chunks +6 lines, -1 line 0 comments Download
M src/libopenusb1-glue.c View 6 chunks +11 lines, -2 lines 0 comments Download
M src/libusb-glue.h View 1 chunk +1 line, -1 line 0 comments Download
M src/libusb-glue.c View 6 chunks +86 lines, -59 lines 0 comments Download
A src/mtpz.h View 1 chunk +51 lines, -0 lines 0 comments Download
A src/mtpz.c View 1 chunk +1814 lines, -0 lines 0 comments Download
M src/music-players.h View 18 chunks +219 lines, -101 lines 0 comments Download
M util/mtp-hotplug.c View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Lei Zhang
The major addition is src/mtpz.c, which should delight Zune users.
8 years, 1 month ago (2012-11-08 02:08:29 UTC) #1
Jorge Lucangeli Obes
Are we going to provide all those values mtpz.c claims it requires? I.e. are we ...
8 years, 1 month ago (2012-11-09 04:30:31 UTC) #2
Lei Zhang
Oh, it does seem this mtpz code is not going to be very useful on ...
8 years, 1 month ago (2012-11-09 04:56:31 UTC) #3
Lei Zhang
Patch set 2 disables mtpz for Linux. I will send a separate CL for disabling ...
8 years, 1 month ago (2012-11-09 09:39:25 UTC) #4
Jorge Lucangeli Obes
https://chromiumcodereview.appspot.com/11358153/diff/19002/config.h File config.h (right): https://chromiumcodereview.appspot.com/11358153/diff/19002/config.h#newcode178 config.h:178: /* #undef USE_MTPZ */ It's weird to have #undef ...
8 years, 1 month ago (2012-11-09 19:59:12 UTC) #5
Lei Zhang
https://chromiumcodereview.appspot.com/11358153/diff/19002/config.h File config.h (right): https://chromiumcodereview.appspot.com/11358153/diff/19002/config.h#newcode178 config.h:178: /* #undef USE_MTPZ */ On 2012/11/09 19:59:12, Jorge Lucangeli ...
8 years, 1 month ago (2012-11-09 20:51:08 UTC) #6
Jorge Lucangeli Obes
8 years, 1 month ago (2012-11-09 21:38:26 UTC) #7
On 2012/11/09 20:51:08, Lei Zhang wrote:
> https://chromiumcodereview.appspot.com/11358153/diff/19002/config.h
> File config.h (right):
> 
> https://chromiumcodereview.appspot.com/11358153/diff/19002/config.h#newcode178
> config.h:178: /* #undef USE_MTPZ */
> On 2012/11/09 19:59:12, Jorge Lucangeli Obes wrote:
> > It's weird to have #undef and the comment... either one would suffice right?
> 
> It's what configure would have generated. Just making it match the rest of the
> file.

lgtm

Powered by Google App Engine
This is Rietveld 408576698