Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 11358131: NaCl: remove dead tests and files from the SCons build. (Closed)

Created:
8 years, 1 month ago by Nick Bray (chromium)
Modified:
8 years, 1 month ago
Reviewers:
Mark Seaborn
CC:
chromium-reviews
Visibility:
Public.

Description

NaCl: remove dead tests and files from the SCons build. ppapi/native_client/tests/ppapi/ contained tests that checked PPAPI headers were compatible with the NaCl toolchain. These tests are no longer relevant. ppapi/native_client/tests/ppapi_simple_tests/ contained dead files. BUG= http://code.google.com/p/chromium/issues/detail?id=154400 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166589

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2877 lines) Patch
M ppapi/native_client/chrome_main.scons View 1 chunk +0 lines, -1 line 0 comments Download
D ppapi/native_client/tests/ppapi/nacl.scons View 1 chunk +0 lines, -62 lines 0 comments Download
D ppapi/native_client/tests/ppapi/opengl_cpp_header_test.cc View 1 chunk +0 lines, -10 lines 0 comments Download
D ppapi/native_client/tests/ppapi/opengl_header_test.c View 1 chunk +0 lines, -12 lines 0 comments Download
D ppapi/native_client/tests/ppapi_simple_tests/audio.cc View 1 chunk +0 lines, -155 lines 0 comments Download
D ppapi/native_client/tests/ppapi_simple_tests/audio.stdin View 1 chunk +0 lines, -116 lines 0 comments Download
D ppapi/native_client/tests/ppapi_simple_tests/audio.stdout View 1 chunk +0 lines, -131 lines 0 comments Download
D ppapi/native_client/tests/ppapi_simple_tests/event.cc View 1 chunk +0 lines, -250 lines 0 comments Download
D ppapi/native_client/tests/ppapi_simple_tests/event.stdin View 1 chunk +0 lines, -135 lines 0 comments Download
D ppapi/native_client/tests/ppapi_simple_tests/event.stdout View 1 chunk +0 lines, -180 lines 0 comments Download
D ppapi/native_client/tests/ppapi_simple_tests/file.cc View 1 chunk +0 lines, -326 lines 0 comments Download
D ppapi/native_client/tests/ppapi_simple_tests/file1.stdin View 1 chunk +0 lines, -88 lines 0 comments Download
D ppapi/native_client/tests/ppapi_simple_tests/file1.stdout View 1 chunk +0 lines, -133 lines 0 comments Download
D ppapi/native_client/tests/ppapi_simple_tests/file2.stdin View 1 chunk +0 lines, -83 lines 0 comments Download
D ppapi/native_client/tests/ppapi_simple_tests/file2.stdout View 1 chunk +0 lines, -91 lines 0 comments Download
D ppapi/native_client/tests/ppapi_simple_tests/graphics2d.cc View 1 chunk +0 lines, -104 lines 0 comments Download
D ppapi/native_client/tests/ppapi_simple_tests/graphics2d.stdin View 1 chunk +0 lines, -63 lines 0 comments Download
D ppapi/native_client/tests/ppapi_simple_tests/graphics2d.stdout View 1 chunk +0 lines, -90 lines 0 comments Download
D ppapi/native_client/tests/ppapi_simple_tests/ppapi_emu_file.stdin View 1 chunk +0 lines, -52 lines 0 comments Download
D ppapi/native_client/tests/ppapi_simple_tests/ppapi_emu_file.stdout View 1 chunk +0 lines, -41 lines 0 comments Download
D ppapi/native_client/tests/ppapi_simple_tests/ppapi_geturl_invalid.stdin View 1 chunk +0 lines, -87 lines 0 comments Download
D ppapi/native_client/tests/ppapi_simple_tests/ppapi_geturl_invalid.stdout View 1 chunk +0 lines, -135 lines 0 comments Download
D ppapi/native_client/tests/ppapi_simple_tests/ppapi_geturl_valid.stdin View 1 chunk +0 lines, -151 lines 0 comments Download
D ppapi/native_client/tests/ppapi_simple_tests/ppapi_geturl_valid.stdout View 1 chunk +0 lines, -272 lines 0 comments Download
D ppapi/native_client/tests/ppapi_simple_tests/sel_universal_ppapi_replay_prolog.stdin View 1 chunk +0 lines, -104 lines 0 comments Download
D ppapi/native_client/tests/ppapi_simple_tests/test.txt View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nick Bray (chromium)
8 years, 1 month ago (2012-11-07 00:17:57 UTC) #1
Mark Seaborn
LGTM, but please add more explanation to the commit message
8 years, 1 month ago (2012-11-07 00:24:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ncbray@chromium.org/11358131/1
8 years, 1 month ago (2012-11-07 23:21:42 UTC) #3
commit-bot: I haz the power
8 years, 1 month ago (2012-11-08 02:50:29 UTC) #4
Change committed as 166589

Powered by Google App Engine
This is Rietveld 408576698