Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11358027: Move constrained web dialog code back to chrome/. (Closed)

Created:
8 years, 1 month ago by Avi (use Gerrit)
Modified:
8 years, 1 month ago
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Move constrained web dialog code back to chrome/. This partially reverts r139757. BUG=107201, 125841 TEST=no visible change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165463

Patch Set 1 #

Patch Set 2 : compilation fixes #

Patch Set 3 : cros fix #

Patch Set 4 : cros fix2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -310 lines) Patch
M chrome/browser/printing/print_preview_tab_controller.cc View 4 chunks +5 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_web_dialog_delegate_mac.mm View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/ui/gtk/constrained_web_dialog_delegate_gtk.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc View 1 2 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/certificate_viewer_ui.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/certificate_viewer_ui.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/certificate_viewer_webui.cc View 1 2 chunks +9 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 3 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/webui/constrained_web_dialog_delegate_base.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/constrained_web_dialog_delegate_base.cc View 1 chunk +0 lines, -1 line 0 comments Download
A + chrome/browser/ui/webui/constrained_web_dialog_ui.h View 4 chunks +14 lines, -16 lines 0 comments Download
A + chrome/browser/ui/webui/constrained_web_dialog_ui.cc View 4 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/constrained_web_dialog_ui_browsertest.cc View 4 chunks +18 lines, -20 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/tab_modal_confirm_dialog_webui.h View 1 2 3 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/tab_modal_confirm_dialog_webui.cc View 1 2 3 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
D ui/web_dialogs/constrained_web_dialog_ui.h View 1 chunk +0 lines, -103 lines 0 comments Download
D ui/web_dialogs/constrained_web_dialog_ui.cc View 1 chunk +0 lines, -109 lines 0 comments Download
M ui/web_dialogs/web_dialogs.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Avi (use Gerrit)
8 years, 1 month ago (2012-11-01 01:04:58 UTC) #1
Ben Goodger (Google)
lgtm
8 years, 1 month ago (2012-11-01 17:25:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/11358027/9001
8 years, 1 month ago (2012-11-01 18:13:07 UTC) #3
commit-bot: I haz the power
8 years, 1 month ago (2012-11-01 19:18:52 UTC) #4 
Change committed as 165463

Powered by Google App Engine
This is Rietveld 408576698