Chromium Code Reviews
Help | Chromium Project | Sign in
(256)

Issue 11358011: Ensure reducing the length of an array doesn't make it go holey. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 9 months ago by Toon Verwaest
Modified:
2 years, 9 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Ensure reducing the length of an array doesn't make it go holey. Also only transition and/or change anything to the backing store if we are actually going to delete anything. BUG= Committed: https://code.google.com/p/v8/source/detail?r=12840

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -27 lines) Patch
M src/elements.cc View 2 chunks +26 lines, -19 lines 0 comments Download
A + test/mjsunit/elements-length-no-holey.js View 1 1 chunk +4 lines, -3 lines 0 comments Download
A + test/mjsunit/regress/regress-delete-empty-double.js View 1 1 chunk +8 lines, -5 lines 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 5 (0 generated)
Toon Verwaest
PTAL
2 years, 9 months ago (2012-10-31 16:40:15 UTC) #1
danno
LGTM if you beef up the tests as indicated https://chromiumcodereview.appspot.com/11358011/diff/1/test/mjsunit/elements-length-no-holey.js File test/mjsunit/elements-length-no-holey.js (right): https://chromiumcodereview.appspot.com/11358011/diff/1/test/mjsunit/elements-length-no-holey.js#newcode32 test/mjsunit/elements-length-no-holey.js:32: ...
2 years, 9 months ago (2012-10-31 18:23:11 UTC) #2
Toon Verwaest
https://chromiumcodereview.appspot.com/11358011/diff/1/test/mjsunit/regress/regress-delete-empty-double.js File test/mjsunit/regress/regress-delete-empty-double.js (right): https://chromiumcodereview.appspot.com/11358011/diff/1/test/mjsunit/regress/regress-delete-empty-double.js#newcode30 test/mjsunit/regress/regress-delete-empty-double.js:30: delete a[0]; Are you sure this should be holey? ...
2 years, 9 months ago (2012-10-31 18:27:28 UTC) #3
danno
https://chromiumcodereview.appspot.com/11358011/diff/1/test/mjsunit/regress/regress-delete-empty-double.js File test/mjsunit/regress/regress-delete-empty-double.js (right): https://chromiumcodereview.appspot.com/11358011/diff/1/test/mjsunit/regress/regress-delete-empty-double.js#newcode30 test/mjsunit/regress/regress-delete-empty-double.js:30: delete a[0]; You're right. How about a second case ...
2 years, 9 months ago (2012-10-31 20:15:09 UTC) #4
Toon Verwaest
2 years, 9 months ago (2012-11-02 09:47:25 UTC) #5
Addressed comments.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 5fa3ca5