Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 11348294: Follow-up to https://chromiumcodereview.appspot.com/11416144/. (Closed)

Created:
8 years ago by aam-me
Modified:
8 years ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Follow-up to https://chromiumcodereview.appspot.com/11416144/. Removed checked mode verification from resolution/members.dart. Added equals operator to MalformedType. Cosmetic clean up. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=15574

Patch Set 1 #

Patch Set 2 : dt -> dartType #

Total comments: 16

Patch Set 3 : Fixed dart2dart malformed type handling in visitNewExpression(). Fixed comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -17 lines) Patch
M sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart View 1 2 1 chunk +8 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 1 2 2 chunks +18 lines, -6 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/builder.dart View 1 2 chunks +9 lines, -7 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/typechecker.dart View 1 chunk +6 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/warnings.dart View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
aam-me
Hi, I picked up Nicolas's feedback from https://chromiumcodereview.appspot.com/11416144/ and tried to address it here in ...
8 years ago (2012-11-29 05:20:44 UTC) #1
ahe
Thank you, Alexander! LGTM
8 years ago (2012-11-29 05:53:52 UTC) #2
Johnni Winther
lgtm
8 years ago (2012-11-29 07:52:18 UTC) #3
ngeoffray
LGTM! Small nits, especially on the big comment you added to explain what's happening. Thanks ...
8 years ago (2012-11-29 09:02:26 UTC) #4
aam-me
Thank you for the reviews, guys! As I was running dart2dart tests I encountered one ...
8 years ago (2012-11-30 06:27:46 UTC) #5
ahe
LGTM, go ahead and submit now.
8 years ago (2012-11-30 06:53:40 UTC) #6
Johnni Winther
8 years ago (2012-11-30 07:47:14 UTC) #7
Yes, go ahead and commit. I'll take handle the mess of merging the two commits.

Powered by Google App Engine
This is Rietveld 408576698