[autofill] Fill in values on a successful run of interactive autocomplete.

chrome/renderer/autofill/form_autofill_util.h

Index: chrome/renderer/autofill/form_autofill_util.h
diff --git a/chrome/renderer/autofill/form_autofill_util.h b/chrome/renderer/autofill/form_autofill_util.h
index b63424f502b2d247904dc38f6327f75404d64046..ff3ce18d7bd8d8105435c9f653c678c46181db47 100644
--- a/chrome/renderer/autofill/form_autofill_util.h
+++ b/chrome/renderer/autofill/form_autofill_util.h
@@ -20,10 +20,11 @@ class WebInputElement;
 
 namespace autofill {
 
-// A bit field mask for form requirements.
+// A bit field mask for form or form element requirements.
 enum RequirementsMask {
-  REQUIRE_NONE         = 0,  // No requirements.
-  REQUIRE_AUTOCOMPLETE = 1,  // Require that autocomplete != off.
+  REQUIRE_NONE         = 0,       // No requirements.
+  REQUIRE_AUTOCOMPLETE = 1 << 0,  // Require that autocomplete != off.
+  REQUIRE_FOCUSABLE    = 1 << 1,  // Require that a form element be focusable.

[Ilya Sherman, 2012/11/30 04:04:54]

Please add this to a separate enum, as it doesn't make sense in quite the same
contexts where the RequirementsMask makes sense.  It's also an implementation
detail, so there's no need to expose it in the header.

[Dan Beam, 2012/11/30 04:13:33]

changed to bool

 };
 
 // A bit field mask to extract data from WebFormControlElement.
@@ -98,6 +99,12 @@ bool FindFormAndFieldForInputElement(const WebKit::WebInputElement& element,
 void FillForm(const FormData& form,
               const WebKit::WebInputElement& element);
 
+// Fills focusable and non-focusable form control elements within |form_element|
+// with field data from |form_data|.
+void FillFormAndNonFocusableElements(

[Ilya Sherman, 2012/11/30 04:04:54]

nit: Perhaps "including" rather than "and"?  The non-focusable elements are part
of the form, rather than separate from it.

[Dan Beam, 2012/11/30 04:13:33]

Done.

+    const FormData& form_data,
+    const WebKit::WebFormElement& form_element);
+
 // Previews the form represented by |form|.  |element| is the input element that
 // initiated the preview process.
 void PreviewForm(const FormData& form,