[autofill] Fill in values on a successful run of interactive autocomplete.

chrome/renderer/autofill/form_autofill_util.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_RENDERER_AUTOFILL_FORM_AUTOFILL_UTIL_H_
 #define CHROME_RENDERER_AUTOFILL_FORM_AUTOFILL_UTIL_H_
 
 #include <vector>
 
 #include "base/string16.h"
 
 struct FormData;
 struct FormFieldData;
 
 namespace WebKit {
 class WebFormElement;
 class WebFormControlElement;
 class WebInputElement;
 }
 
 namespace autofill {
 
-// A bit field mask for form requirements.
+// A bit field mask for form or form element requirements.
 enum RequirementsMask {
-  REQUIRE_NONE         = 0,  // No requirements.
-  REQUIRE_AUTOCOMPLETE = 1,  // Require that autocomplete != off.
+  REQUIRE_NONE         = 0,       // No requirements.
+  REQUIRE_AUTOCOMPLETE = 1 << 0,  // Require that autocomplete != off.
+  REQUIRE_FOCUSABLE    = 1 << 1,  // Require that a form element be focusable.

[Ilya Sherman, 2012/11/30 04:04:54]

Please add this to a separate enum, as it doesn't make sense in quite the same
contexts where the RequirementsMask makes sense.  It's also an implementation
detail, so there's no need to expose it in the header.

[Dan Beam, 2012/11/30 04:13:33]

changed to bool

 };
 
 // A bit field mask to extract data from WebFormControlElement.
 enum ExtractMask {
   EXTRACT_NONE        = 0,
   EXTRACT_VALUE       = 1 << 0,  // Extract value from WebFormControlElement.
   EXTRACT_OPTION_TEXT = 1 << 1,  // Extract option text from
                                  // WebFormSelectElement. Only valid when
                                  // |EXTRACT_VALUE| is set.
                                  // This is used for form submission where
@@ skipping 54 matching lines @@
 bool FindFormAndFieldForInputElement(const WebKit::WebInputElement& element,
                                      FormData* form,
                                      FormFieldData* field,
                                      RequirementsMask requirements);
 
 // Fills the form represented by |form|.  |element| is the input element that
 // initiated the auto-fill process.
 void FillForm(const FormData& form,
               const WebKit::WebInputElement& element);
 
+// Fills focusable and non-focusable form control elements within |form_element|
+// with field data from |form_data|.
+void FillFormAndNonFocusableElements(

[Ilya Sherman, 2012/11/30 04:04:54]

nit: Perhaps "including" rather than "and"?  The non-focusable elements are part
of the form, rather than separate from it.

[Dan Beam, 2012/11/30 04:13:33]

Done.

+    const FormData& form_data,
+    const WebKit::WebFormElement& form_element);
+
 // Previews the form represented by |form|.  |element| is the input element that
 // initiated the preview process.
 void PreviewForm(const FormData& form,
                  const WebKit::WebInputElement& element);
 
 // Clears the placeholder values and the auto-filled background for any fields
 // in the form containing |node| that have been previewed.  Resets the
 // autofilled state of |node| to |was_autofilled|.  Returns false if the form is
 // not found.
 bool ClearPreviewedFormWithElement(const WebKit::WebInputElement& element,
                                    bool was_autofilled);
 
 // Returns true if |form| has any auto-filled fields.
 bool FormWithElementIsAutofilled(const WebKit::WebInputElement& element);
 
 }  // namespace autofill
 
 #endif  // CHROME_RENDERER_AUTOFILL_FORM_AUTOFILL_UTIL_H_