Issue 11348254: Remove old transaction() call, proxies, and messages.

Issue 11348254: Remove old transaction() call, proxies, and messages. (Closed)

Created:
8 years ago by alecflett

Modified:
8 years ago

Reviewers:
Tom Sepez, dgrogan, jsbell

CC:
chromium-reviews, joi+watch-content_chromium.org, jam, darin-cc_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@create-transaction-int

Visibility:
Public.

More Reviews

Description

Remove old transaction() call, proxies, and messages. BUG=161958 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170463

Patch Set 2 : update to ToT for landing #

Total comments: 1

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -76 lines)			Patch
M	content/browser/in_process_webkit/indexed_db_dispatcher_host.h	View	1	1 chunk	+0 lines, -7 lines	0 comments	Download
M	content/browser/in_process_webkit/indexed_db_dispatcher_host.cc	View	1	2 chunks	+0 lines, -26 lines	0 comments	Download
M	content/common/indexed_db/indexed_db_messages.h	View	1	1 chunk	+1 line, -15 lines	1 comment	Download
M	content/common/indexed_db/proxy_webidbdatabase_impl.h	View	1	2 chunks	+0 lines, -9 lines	0 comments	Download
M	content/common/indexed_db/proxy_webidbdatabase_impl.cc	View	1	1 chunk	+0 lines, -19 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

alecflett

jsbell / dgrogan / tsepez - just removal of the messages from the first transaction ...

8 years ago (2012-11-29 19:14:22 UTC) #1

dgrogan

lgtm https://codereview.chromium.org/11348254/diff/1006/content/common/indexed_db/indexed_db_messages.h File content/common/indexed_db/indexed_db_messages.h (right): https://codereview.chromium.org/11348254/diff/1006/content/common/indexed_db/indexed_db_messages.h#newcode40 content/common/indexed_db/indexed_db_messages.h:40: IPC_STRUCT_BEGIN(IndexedDBHostMsg_FactoryOpen_Params) only tangentially related to this CL: Eventually ...

8 years ago (2012-11-29 19:19:41 UTC) #3

alecflett

On 2012/11/29 19:19:41, dgrogan wrote: > lgtm > > https://codereview.chromium.org/11348254/diff/1006/content/common/indexed_db/indexed_db_messages.h > File content/common/indexed_db/indexed_db_messages.h (right): > ...

8 years ago (2012-11-29 20:10:22 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alecflett@chromium.org/11348254/1006

8 years ago (2012-11-29 20:28:18 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alecflett@chromium.org/11348254/1006

8 years ago (2012-11-30 15:42:44 UTC) #6

Message was sent while issue was closed.

Change committed as 170463

Expand Messages | Collapse Messages