content/common/indexed_db/proxy_webidbdatabase_impl.h - Issue 11348254: Remove old transaction() call, proxies, and messages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/indexed_db/proxy_webidbdatabase_impl.h

Issue 11348254: Remove old transaction() call, proxies, and messages. (Closed) Base URL: http://git.chromium.org/chromium/src.git@create-transaction-int

Patch Set: update to ToT for landing Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/common/indexed_db/indexed_db_messages.h ('K') | « content/common/indexed_db/indexed_db_messages.h ('k') | content/common/indexed_db/proxy_webidbdatabase_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/indexed_db/proxy_webidbdatabase_impl.h

diff --git a/content/common/indexed_db/proxy_webidbdatabase_impl.h b/content/common/indexed_db/proxy_webidbdatabase_impl.h

index 6d459b08c0d56a446ca2f3937dbb3e458a5f2946..a4bfac14360d863bbdb17cff7f9ee2918f058e76 100644

--- a/content/common/indexed_db/proxy_webidbdatabase_impl.h

+++ b/content/common/indexed_db/proxy_webidbdatabase_impl.h

@@ -22,10 +22,6 @@ class RendererWebIDBDatabaseImpl : public WebKit::WebIDBDatabase {

explicit RendererWebIDBDatabaseImpl(int32 idb_database_id);

virtual ~RendererWebIDBDatabaseImpl();

- // TODO(alecflett): Remove this when it is removed from webkit:

- // https://bugs.webkit.org/show_bug.cgi?id=98085

- static const long long AutogenerateObjectStoreId = -1;

// WebKit::WebIDBDatabase

virtual WebKit::WebIDBMetadata metadata() const;

virtual WebKit::WebIDBObjectStore* createObjectStore(

@@ -39,11 +35,6 @@ class RendererWebIDBDatabaseImpl : public WebKit::WebIDBDatabase {

long long object_store_id,

const WebKit::WebIDBTransaction& transaction,

WebKit::WebExceptionCode& ec);

- // TODO(alecflett): Remove this as part of

- // https://bugs.webkit.org/show_bug.cgi?id=102733.

- virtual WebKit::WebIDBTransaction* transaction(

- const WebKit::WebVector<long long>& scope,

- unsigned short mode);

virtual WebKit::WebIDBTransaction* createTransaction(

long long transaction_id,

const WebKit::WebVector<long long>& scope,