rietveld.py - Issue 11348122: Add presubmit check to verify issue is not closed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: rietveld.py

Issue 11348122: Add presubmit check to verify issue is not closed. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: addr M-A comments, refactored rietveld call Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: rietveld.py

diff --git a/rietveld.py b/rietveld.py

index d4ac39bab08060ea3c6414d3b9ad32b986d266f0..cab91407e481839c3a953c9666fe018162b7a449 100644

--- a/rietveld.py

+++ b/rietveld.py

@@ -86,7 +86,7 @@ class Rietveld(object):

def get_issue_properties(self, issue, messages):

"""Returns all the issue's metadata as a dictionary."""

- url = '/api/%d' % issue

+ url = '/api/%s' % issue

M-A Ruel 2012/11/21 20:48:38 Why? It was %d on purpose.

if messages:

url += '?messages=true'

return json.loads(self.get(url))