Add presubmit check to verify issue is not closed.

rietveld.py

 # coding: utf-8
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 """Defines class Rietveld to easily access a rietveld instance.
 
 Security implications:
 
 The following hypothesis are made:
 - Rietveld enforces:
@@ skipping 68 matching lines @@
     """Closes the Rietveld issue for this changelist."""
     logging.info('closing issue %d' % issue)
     self.post("/%d/close" % issue, [('xsrf_token', self.xsrf_token())])
 
   def get_description(self, issue):
     """Returns the issue's description."""
     return self.get('/%d/description' % issue)
 
   def get_issue_properties(self, issue, messages):
     """Returns all the issue's metadata as a dictionary."""
-    url = '/api/%d' % issue
+    url = '/api/%s' % issue

[M-A Ruel, 2012/11/21 20:48:38]

Why? It was %d on purpose.

     if messages:
       url += '?messages=true'
     return json.loads(self.get(url))
 
   def get_patchset_properties(self, issue, patchset):
     """Returns the patchset properties."""
     url = '/api/%d/%d' % (issue, patchset)
     return json.loads(self.get(url))
 
   def get_file_content(self, issue, patchset, item):
@@ skipping 288 matching lines @@
           if not 'Name or service not known' in e.reason:
             # Usually internal GAE flakiness.
             raise
         # If reaching this line, loop again. Uses a small backoff.
         time.sleep(1+maxtries*2)
     finally:
       upload.ErrorExit = old_error_exit
 
   # DEPRECATED.
   Send = get