[Android WebView] AwContentsClient.shouldCreate window callback part 2.

android_webview/browser/aw_contents_io_thread_client.h

Index: android_webview/browser/aw_contents_io_thread_client.h
diff --git a/android_webview/browser/aw_contents_io_thread_client.h b/android_webview/browser/aw_contents_io_thread_client.h
index 0dd414623db006fad9cc079441187f97612fc37a..f642065e4ba0cf40073c15b6cca8672ed6f0ef0d 100644
--- a/android_webview/browser/aw_contents_io_thread_client.h
+++ b/android_webview/browser/aw_contents_io_thread_client.h
@@ -43,6 +43,14 @@ class AwContentsIoThreadClient {
   static scoped_ptr<AwContentsIoThreadClient> FromID(int render_process_id,
                                                      int render_view_id);
 
+  class ReadyObserver {

[joth, 2012/11/16 06:24:31]

docs

[benm (inactive), 2012/11/16 12:29:09]

Done.

+   public:
+    virtual void OnIoThreadClientReady(int child_id, int route_id) = 0;
+  };
+

[mkosiba (inactive), 2012/11/16 12:28:32]

I think the usual pattern is to declare ReadyObserver as friend and make these
methods private.

[benm (inactive), 2012/11/16 12:36:31]

Do you have a precedent? I had a quick look at some other users and couldn't see
that pattern being used.

[mkosiba (inactive), 2012/11/16 13:55:18]

I got the idea from WebContentsObserver being friends with WebContentsImpl, but
you're right - it doesn't look like it's used consistently everywhere.

[benm (inactive), 2012/11/16 14:00:26]

OK, thanks. think i will leave as is then.

+  static void AddReadyObserver(ReadyObserver* obs);
+  static void RemoveReadyObserver(ReadyObserver* obs);
+
   // This method is called on the IO thread only.
   virtual scoped_ptr<InterceptedRequestData> ShouldInterceptRequest(
       const GURL& location,