[Android WebView] AwContentsClient.shouldCreate window callback part 2.

android_webview/browser/aw_contents_io_thread_client.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ANDROID_WEBVIEW_BROWSER_AW_CONTENTS_IO_THREAD_CLIENT_H_
 #define ANDROID_WEBVIEW_BROWSER_AW_CONTENTS_IO_THREAD_CLIENT_H_
 
 #include "base/memory/scoped_ptr.h"
 
 class GURL;
@@ skipping 25 matching lines @@
  public:
   virtual ~AwContentsIoThreadClient() {}
 
   // This will attempt to fetch the AwContentsIoThreadClient for the given
   // |render_process_id|, |render_view_id| pair.
   // This method can be called from any thread.
   // An empty scoped_ptr is a valid return value.
   static scoped_ptr<AwContentsIoThreadClient> FromID(int render_process_id,
                                                      int render_view_id);
 
+  class ReadyObserver {

[joth, 2012/11/16 06:24:31]

docs

[benm (inactive), 2012/11/16 12:29:09]

Done.

+   public:
+    virtual void OnIoThreadClientReady(int child_id, int route_id) = 0;
+  };
+

[mkosiba (inactive), 2012/11/16 12:28:32]

I think the usual pattern is to declare ReadyObserver as friend and make these
methods private.

[benm (inactive), 2012/11/16 12:36:31]

Do you have a precedent? I had a quick look at some other users and couldn't see
that pattern being used.

[mkosiba (inactive), 2012/11/16 13:55:18]

I got the idea from WebContentsObserver being friends with WebContentsImpl, but
you're right - it doesn't look like it's used consistently everywhere.

[benm (inactive), 2012/11/16 14:00:26]

OK, thanks. think i will leave as is then.

+  static void AddReadyObserver(ReadyObserver* obs);
+  static void RemoveReadyObserver(ReadyObserver* obs);
+
   // This method is called on the IO thread only.
   virtual scoped_ptr<InterceptedRequestData> ShouldInterceptRequest(
       const GURL& location,
       const net::URLRequest* request) = 0;
 
   // Retrieve the AllowContentAccess setting value of this AwContents.
   // This method is called on the IO thread only.
   virtual bool ShouldBlockContentUrls() const = 0;
 
   // Retrieve the AllowFileAccess setting value of this AwContents.
   // This method is called on the IO thread only.
   virtual bool ShouldBlockFileUrls() const = 0;
 
   // Retrieve the BlockNetworkLoads setting value of this AwContents.
   // This method is called on the IO thread only.
   virtual bool ShouldBlockNetworkLoads() const = 0;
 };
 
 } // namespace android_webview
 
 #endif  // ANDROID_WEBVIEW_BROWSER_AW_CONTENTS_IO_THREAD_CLIENT_H_