Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 11348030: Revert 164876 - Set root resource ID upon full feed update. (Closed)

Created:
8 years, 1 month ago by kochi
Modified:
8 years, 1 month ago
Reviewers:
kochi
CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Revert 164876 - Set root resource ID upon full feed update. We used to set the resource ID at DriveResourceMetadata's constructor as for WAPI the resource ID for root is a fixed string, but for Drive API it is not fixed and was set when About resource is obtained. This caused a trouble for maintaining the code and this CL is trying to consolidate setting root resource ID at one place. Although for Drive API 'root' can be used for a convenient alias for queries, Drive API usually returns a reference to root directory (e.g. reference to parent folder) as its real root directory resource ID rather than 'root' alias, therefore we don't use it here. BUG=152230, 152288, 157314 TEST=compiles, pass all existing tests. Review URL: https://chromiumcodereview.appspot.com/11227020 TBR=kochi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=164883

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -81 lines) Patch
M chrome/browser/chromeos/drive/drive_feed_loader.h View 2 chunks +3 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_feed_loader.cc View 3 chunks +3 lines, -20 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_file_system_unittest.cc View 4 chunks +3 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_resource_metadata.h View 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_resource_metadata.cc View 8 chunks +10 lines, -18 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_resource_metadata_unittest.cc View 7 chunks +4 lines, -15 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_test_util.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
kochi
8 years, 1 month ago (2012-10-30 09:21:42 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698