Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 11348005: Change the handling og the HTTP content length (Closed)

Created:
8 years, 1 month ago by Søren Gjesse
Modified:
8 years, 1 month ago
Reviewers:
Mads Ager (google)
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Change the handling og the HTTP content length This change should make the indicated HTTP message content length be as described in RFC 2616. For requests the content length is 0 if neither Content-Length nor Transfer-Encoding headers are set. If the content length of a request is set to 0 the Content-Length header is not sent with a value of 0. For GET and HEAD the content length is set to 0 by default. For responses content length needs to be set to 0 to indicate an empty response (unless it is a HEAD response where the content length indicate the size of the body expected). Otherwise a body is assumed and if no content length is set chunked transfer encoding is used. For HTTP 1.0 chunked transfer encoding is not supported. So for HTTP 1.0 requests needs content length if they have a body and responses without a content length will indicate end of body by closing the connection. R=ager@google.com BUG=dart:6309 Committed: https://code.google.com/p/dart/source/detail?r=14184

Patch Set 1 #

Patch Set 2 : Minor fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -22 lines) Patch
M runtime/bin/http_impl.dart View 1 6 chunks +19 lines, -15 lines 0 comments Download
M runtime/bin/http_parser.dart View 2 chunks +8 lines, -2 lines 0 comments Download
M tests/standalone/io/http_content_length_test.dart View 6 chunks +18 lines, -4 lines 0 comments Download
M tests/standalone/io/http_parser_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Gjesse
8 years, 1 month ago (2012-10-29 11:08:43 UTC) #1
Mads Ager (google)
8 years, 1 month ago (2012-10-29 11:24:29 UTC) #2
LGTM!

Powered by Google App Engine
This is Rietveld 408576698