Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 11344028: [Autofill] Add a unit test for the autofill_regexes code. (Closed)

Created:
8 years, 1 month ago by Ilya Sherman
Modified:
8 years, 1 month ago
Reviewers:
Albert Bodenhamer, Nico
CC:
chromium-reviews, dhollowa+watch_chromium.org, Ilya Sherman, browser-components-watch_chromium.org, dyu1
Visibility:
Public.

Description

[Autofill] Add a unit test for the autofill_regexes code. BUG=none TBR=thakis@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165043

Patch Set 1 #

Patch Set 2 : ...add the test file #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -1 line) Patch
M chrome/browser/autofill/autofill_regexes.cc View 1 chunk +0 lines, -1 line 2 comments Download
A chrome/browser/autofill/autofill_regexes_unittest.cc View 1 1 chunk +60 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Ilya Sherman
Noticed while debugging that this file had no test coverage.
8 years, 1 month ago (2012-10-30 01:09:24 UTC) #1
Albert Bodenhamer
https://chromiumcodereview.appspot.com/11344028/diff/1003/chrome/browser/autofill/autofill_regexes.cc File chrome/browser/autofill/autofill_regexes.cc (right): https://chromiumcodereview.appspot.com/11344028/diff/1003/chrome/browser/autofill/autofill_regexes.cc#newcode83 chrome/browser/autofill/autofill_regexes.cc:83: } // namespace autofill Other than whitespace changes I'm ...
8 years, 1 month ago (2012-10-30 20:28:40 UTC) #2
Ilya Sherman
https://chromiumcodereview.appspot.com/11344028/diff/1003/chrome/browser/autofill/autofill_regexes.cc File chrome/browser/autofill/autofill_regexes.cc (right): https://chromiumcodereview.appspot.com/11344028/diff/1003/chrome/browser/autofill/autofill_regexes.cc#newcode83 chrome/browser/autofill/autofill_regexes.cc:83: } // namespace autofill On 2012/10/30 20:28:41, Albert Bodenhamer ...
8 years, 1 month ago (2012-10-30 20:34:09 UTC) #3
Albert Bodenhamer
lgtm
8 years, 1 month ago (2012-10-30 20:36:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/11344028/1003
8 years, 1 month ago (2012-10-30 20:40:52 UTC) #5
commit-bot: I haz the power
Presubmit check for 11344028-1003 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 1 month ago (2012-10-30 20:40:58 UTC) #6
Ilya Sherman
TBR Nico for the gyp change
8 years, 1 month ago (2012-10-30 20:43:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/11344028/1003
8 years, 1 month ago (2012-10-30 20:43:47 UTC) #8
Nico
lgtm
8 years, 1 month ago (2012-10-30 20:45:19 UTC) #9
commit-bot: I haz the power
8 years, 1 month ago (2012-10-30 22:49:19 UTC) #10
Change committed as 165043

Powered by Google App Engine
This is Rietveld 408576698