Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 11342033: Allow IDL schemas to have comments on callback functions (Closed)

Created:
8 years, 1 month ago by cduvall
Modified:
8 years, 1 month ago
CC:
chromium-reviews, Aaron Boodman, pam+watch_chromium.org, chromium-apps-reviews_chromium.org, mkearney1
Visibility:
Public.

Description

Allow IDL schemas to have comments on callback functions The JSON schema compiler was ignoring comments on callback functions. Now callback functions and their parameters can have comments. BUG=158459 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165613

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Clarify comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -7 lines) Patch
M chrome/common/extensions/docs/templates/private/callback.html View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/json_schema_compiler/idl_schema.py View 2 chunks +8 lines, -2 lines 0 comments Download
M tools/json_schema_compiler/idl_schema_test.py View 1 3 chunks +19 lines, -5 lines 0 comments Download
M tools/json_schema_compiler/test/idl_basics.idl View 1 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
cduvall
miket: You seemed to be the best to review this. If not, just let me ...
8 years, 1 month ago (2012-10-30 02:23:37 UTC) #1
miket_OOO
This is *probably* OK, but I'd be more comfortable with Antony reviewing it (added).
8 years, 1 month ago (2012-10-31 17:06:45 UTC) #2
asargent_no_longer_on_chrome
lgtm w/ one nit https://codereview.chromium.org/11342033/diff/2001/tools/json_schema_compiler/test/idl_basics.idl File tools/json_schema_compiler/test/idl_basics.idl (right): https://codereview.chromium.org/11342033/diff/2001/tools/json_schema_compiler/test/idl_basics.idl#newcode32 tools/json_schema_compiler/test/idl_basics.idl:32: // |x|: A parameter with ...
8 years, 1 month ago (2012-11-01 16:55:36 UTC) #3
cduvall
https://codereview.chromium.org/11342033/diff/2001/tools/json_schema_compiler/test/idl_basics.idl File tools/json_schema_compiler/test/idl_basics.idl (right): https://codereview.chromium.org/11342033/diff/2001/tools/json_schema_compiler/test/idl_basics.idl#newcode32 tools/json_schema_compiler/test/idl_basics.idl:32: // |x|: A parameter with no parent callback. On ...
8 years, 1 month ago (2012-11-01 22:56:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cduvall@chromium.org/11342033/5002
8 years, 1 month ago (2012-11-01 22:57:09 UTC) #5
commit-bot: I haz the power
8 years, 1 month ago (2012-11-02 04:17:24 UTC) #6
Change committed as 165613

Powered by Google App Engine
This is Rietveld 408576698