Allow IDL schemas to have comments on callback functions

Allow IDL schemas to have comments on callback functions

The JSON schema compiler was ignoring comments on callback functions. Now
callback functions and their parameters can have comments.

BUG=158459
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165613

[cduvall, 2012-10-30 02:23:37]

miket: You seemed to be the best to review this. If not, just let me know.
Thanks!

[miket_OOO, 2012-10-31 17:06:45]

This is *probably* OK, but I'd be more comfortable with Antony reviewing it
(added).

[asargent_no_longer_on_chrome, 2012-11-01 16:55:36]

lgtm w/ one nit

https://codereview.chromium.org/11342033/diff/2001/tools/json_schema_compiler...
File tools/json_schema_compiler/test/idl_basics.idl (right):

https://codereview.chromium.org/11342033/diff/2001/tools/json_schema_compiler...
tools/json_schema_compiler/test/idl_basics.idl:32: // |x|: A parameter with no
parent callback.
nit: I don't quite understand the "with no parent callback" part of this
comment. Did you mean "with no parent comment"? (That's still confusing though,
because it looks like your function18 test below does use Callback7 both with
and without a parent comment.

[cduvall, 2012-11-01 22:56:01]

https://codereview.chromium.org/11342033/diff/2001/tools/json_schema_compiler...
File tools/json_schema_compiler/test/idl_basics.idl (right):

https://codereview.chromium.org/11342033/diff/2001/tools/json_schema_compiler...
tools/json_schema_compiler/test/idl_basics.idl:32: // |x|: A parameter with no
parent callback.
On 2012/11/01 16:55:37, Antony Sargent wrote:
> nit: I don't quite understand the "with no parent callback" part of this
> comment. Did you mean "with no parent comment"? (That's still confusing
though,
> because it looks like your function18 test below does use Callback7 both with
> and without a parent comment.

Done, should be more clear now.

[commit-bot: I haz the power, 2012-11-01 22:57:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/cduvall@chromium.org/11342033/5002

[commit-bot: I haz the power, 2012-11-02 04:17:24]

Change committed as 165613