Issue 11341012: Added some new tests for issue 6311

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11341012: Added some new tests for issue 6311 (Closed)

Created:
8 years, 1 month ago by siva

Modified:
8 years, 1 month ago

Reviewers:
srdjan, Ivan Posva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/tests/

Visibility:
Public.

More Reviews

Description

Added some new tests for issue 6311 Committed: https://code.google.com/p/dart/source/detail?r=14226

Patch Set 3 : #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+274 lines, -0 lines)			Patch
	A	standalone/typed_array_test.dart	View	1 2	1 chunk	+274 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM -ip https://chromiumcodereview.appspot.com/11341012/diff/3001/standalone/typed_array_test.dart File standalone/typed_array_test.dart (right): https://chromiumcodereview.appspot.com/11341012/diff/3001/standalone/typed_array_test.dart#newcode31 standalone/typed_array_test.dart:31: port.receive((m, r) { m is not being ...

8 years, 1 month ago (2012-10-29 18:27:45 UTC) #3

siva

8 years, 1 month ago (2012-10-29 20:04:03 UTC) #5

https://chromiumcodereview.appspot.com/11341012/diff/3001/standalone/typed_ar...
File standalone/typed_array_test.dart (right):

https://chromiumcodereview.appspot.com/11341012/diff/3001/standalone/typed_ar...
standalone/typed_array_test.dart:31: port.receive((m, r) {
As discussed offline replaced "hi" with length of the typed array and use it for
allocating the typed array in the spawned function. The actual length of the
typed array sent back is verified against this original length.

On 2012/10/29 18:27:45, Ivan Posva wrote:
> m is not being used below, maybe it should be on of the fields?

Expand Messages | Collapse Messages

Issue 11341012: Added some new tests for issue 6311 (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages