Account for server vs host clock skew in cookie expiration times.

Account for server vs host clock skew in cookie expiration times.
When setting a cookie's expiration time in the cookie store we need
to take into account any difference between the HTTP server and the
host machine's real time clock.  This reverts 159685 which reverted 146616.

BUG=135131
TEST=net_unittests --gtest_filter=CookieMonster/CookieStoreTest/0.TestCookieDeletion

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165323

[pauljensen, 2012-10-30 01:14:35]

Erik & Szymon, this is simply a revert of Erik's change which reverted my
original change.  I literally just used "git revert" so I don't know how
thoroughly it needs to be reviewed.  I think we should reland this now that
crbug.com/153759 is fixed.

[szym, 2012-10-30 01:27:02]

Rubber stamp LGTM.
Is there a test case which covers the case that caused the revert?

[erikwright (departed), 2012-10-30 02:00:01]

Also rubberstamp LGTM.

Also agree that a new test case covering that failure would be appropriate.

It would probably be easiest to write in url_request_tests.cc

[cbentzel, 2012-10-30 18:10:02]

I would suggest waiting to land this after the branch point has been
announced.

On Mon, Oct 29, 2012 at 10:00 PM, <erikwright@chromium.org> wrote:

> Also rubberstamp LGTM.
>
> Also agree that a new test case covering that failure would be appropriate.
>
> It would probably be easiest to write in url_request_tests.cc
>
>
https://codereview.chromium.**org/11339032/<https://codereview.chromium.org/1...
>

[erikwright (departed), 2012-10-30 18:11:37]

Oh, don't worry, it's a totally different release manager this time.
They'll never realize we awesomed-up two releases in a row ;)

On Tue, Oct 30, 2012 at 2:10 PM, Chris Bentzel <cbentzel@chromium.org>wrote:

> I would suggest waiting to land this after the branch point has been
> announced.
>
> On Mon, Oct 29, 2012 at 10:00 PM, <erikwright@chromium.org> wrote:
>
>> Also rubberstamp LGTM.
>>
>> Also agree that a new test case covering that failure would be
>> appropriate.
>>
>> It would probably be easiest to write in url_request_tests.cc
>>
>>
https://codereview.chromium.**org/11339032/<https://codereview.chromium.org/1...
>>
>
>

[pauljensen, 2012-10-30 19:23:38]

I will not land prior to branch point. PTAL at additional test case.

[szym, 2012-10-30 19:52:53]

Test case LGTM.

http://codereview.chromium.org/11339032/diff/6001/net/url_request/url_request...
File net/url_request/url_request_unittest.cc (right):

http://codereview.chromium.org/11339032/diff/6001/net/url_request/url_request...
net/url_request/url_request_unittest.cc:1749:
FixedDateNetworkDelegate(std::string fixed_date);
nit: make explicit, use const &

http://codereview.chromium.org/11339032/diff/6001/net/url_request/url_request...
net/url_request/url_request_unittest.cc:1750: virtual
~FixedDateNetworkDelegate();
I'd make all methods inline here.

[erikwright (departed), 2012-10-31 00:44:30]

test-case LGTM.

[erikwright (departed), 2012-10-31 00:46:03]

Note that this might fail when run under the chrome_frame_net_tests. If so, you
should just blacklist it in fake_external_tab.cc.

You'll know after running it through the win try bots.

[pauljensen, 2012-10-31 16:58:58]

Erik, the test did in fact fail with chrome frame, so I disabled it.  PTAL at
fake_external_tab.cc

Mark, PTAL at chrome/browser/browsing_data/browsing_data_cookie_helper.cc where
I simply duplicated some code into some code you just recently duplicated that
it seems you plan to deduplicate.  By duplicating the code I hope to make it
simpler for you to deduplicate.

[pauljensen, 2012-10-31 17:02:13]

Markus, my apologies for accidentally calling you Mark.

On 2012/10/31 16:58:58, pauljensen wrote:
> Mark, PTAL at chrome/browser/browsing_data/browsing_data_cookie_helper.cc
where
> I simply duplicated some code into some code you just recently duplicated that
> it seems you plan to deduplicate.  By duplicating the code I hope to make it
> simpler for you to deduplicate.

[erikwright (departed), 2012-10-31 17:08:50]

fake_external_tab.cc LGTM

[markusheintz_, 2012-10-31 19:07:09]

browsing_data_helper changed LGTM

[commit-bot: I haz the power, 2012-10-31 20:49:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pauljensen@chromium.org/11339032/12001

[commit-bot: I haz the power, 2012-10-31 21:56:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pauljensen@chromium.org/11339032/19002

[commit-bot: I haz the power, 2012-11-01 10:29:18]

Change committed as 165323