Account for server vs host clock skew in cookie expiration times.

net/url_request/url_request_http_job.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/url_request/url_request_http_job.h"
 
 #include "base/base_switches.h"
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
@@ skipping 548 matching lines @@
   DCHECK(transaction_.get());
 
   const HttpResponseInfo* response_info = transaction_->GetResponseInfo();
   DCHECK(response_info);
 
   response_cookies_.clear();
   response_cookies_save_index_ = 0;
 
   FetchResponseCookies(&response_cookies_);
 
+  if (!GetResponseHeaders()->GetDateValue(&response_date_))
+    response_date_ = base::Time();
+
   // Now, loop over the response cookies, and attempt to persist each.
   SaveNextCookie();
 }
 
 // If the save occurs synchronously, SaveNextCookie will loop and save the next
 // cookie. If the save is deferred, the callback is responsible for continuing
 // to iterate through the cookies.
 // TODO(erikwright): Modify the CookieStore API to indicate via return value
 // whether it completed synchronously or asynchronously.
 // See http://crbug.com/131066.
 void URLRequestHttpJob::SaveNextCookie() {
   // No matter what, we want to report our status as IO pending since we will
   // be notifying our consumer asynchronously via OnStartCompleted.
   SetStatus(URLRequestStatus(URLRequestStatus::IO_PENDING, 0));
 
   // Used to communicate with the callback. See the implementation of
   // OnCookieSaved.
   scoped_refptr<SharedBoolean> callback_pending = new SharedBoolean(false);
   scoped_refptr<SharedBoolean> save_next_cookie_running =
       new SharedBoolean(true);
 
   if (!(request_info_.load_flags & LOAD_DO_NOT_SAVE_COOKIES) &&
       request_->context()->cookie_store() &&
       response_cookies_.size() > 0) {
     CookieOptions options;
     options.set_include_httponly();
+    options.set_server_time(response_date_);
 
     net::CookieStore::SetCookiesCallback callback(
         base::Bind(&URLRequestHttpJob::OnCookieSaved,
                    weak_factory_.GetWeakPtr(),
                    save_next_cookie_running,
                    callback_pending));
 
     // Loop through the cookies as long as SetCookieWithOptionsAsync completes
     // synchronously.
     while (!callback_pending->data &&
@@ skipping 910 matching lines @@
 
 void URLRequestHttpJob::NotifyURLRequestDestroyed() {
   awaiting_callback_ = false;
 }
 
 void URLRequestHttpJob::OnDetachRequest() {
   http_transaction_delegate_->OnDetachRequest();
 }
 
 }  // namespace net