Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11316315: Remove ui::LayerAnimationSequence::duration and ui::LayerAnimationElement::duration. (Closed)

Created:
8 years ago by ajuma
Modified:
8 years ago
Reviewers:
Ian Vollick
CC:
chromium-reviews, piman+watch_chromium.org, jonathan.backer
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Remove ui::LayerAnimationSequence::duration and ui::LayerAnimationElement::duration. This change is in preparation for threading certain ui animations. When we do this, the actual duration of an element will not be known ahead of time, since dispatching the element to the compositor thread will involve a small delay. BUG=164206 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171112

Patch Set 1 #

Patch Set 2 : Make unit tests use IsFinished() instead of duration() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -80 lines) Patch
M ui/compositor/layer_animation_element.h View 2 chunks +12 lines, -8 lines 0 comments Download
M ui/compositor/layer_animation_element.cc View 1 chunk +17 lines, -1 line 0 comments Download
M ui/compositor/layer_animation_element_unittest.cc View 1 14 chunks +40 lines, -26 lines 0 comments Download
M ui/compositor/layer_animation_sequence.h View 3 chunks +10 lines, -12 lines 0 comments Download
M ui/compositor/layer_animation_sequence.cc View 3 chunks +51 lines, -22 lines 0 comments Download
M ui/compositor/layer_animation_sequence_unittest.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M ui/compositor/layer_animator.cc View 5 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
ajuma
PTAL.
8 years ago (2012-12-03 22:25:46 UTC) #1
Ian Vollick
On 2012/12/03 22:25:46, ajuma wrote: > PTAL. Nice! LGTM pending green try jobs.
8 years ago (2012-12-04 16:26:06 UTC) #2
ajuma
vollick@, PTAL at the unit test changes.
8 years ago (2012-12-04 20:43:33 UTC) #3
Ian Vollick
On 2012/12/04 20:43:33, ajuma wrote: > vollick@, PTAL at the unit test changes. Cool. slgtm.
8 years ago (2012-12-04 21:02:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajuma@chromium.org/11316315/6001
8 years ago (2012-12-04 21:05:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajuma@chromium.org/11316315/6001
8 years ago (2012-12-05 00:50:19 UTC) #6
commit-bot: I haz the power
8 years ago (2012-12-05 01:19:32 UTC) #7
Message was sent while issue was closed. 
Change committed as 171112

Powered by Google App Engine
This is Rietveld 408576698