Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11316299: Enable web-based sign in flow by default. Can use command line argument (Closed)

Created:
8 years ago by Roger Tawa OOO till Jul 10th
Modified:
8 years ago
CC:
chromium-reviews, Raghu Simha, haitaol1, akalin, tim (not reviewing)
Visibility:
Public.

Description

Enable web-based sign in flow by default. Can use command line argument --enable-client-login-signin-flow to go back to old behaviour. BUG=81265 TEST=Make sure that command line argument toggles state correctly. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171983

Patch Set 1 : Latest changes #

Patch Set 2 : Fix grd comments #

Patch Set 3 : rebased #

Total comments: 1

Patch Set 4 : Rebased and merged #

Patch Set 5 : rebased #

Patch Set 6 : rebased #

Patch Set 7 : Fix unit tests on trybots #

Patch Set 8 : Fix unit tests #

Patch Set 9 : rebased #

Patch Set 10 : rebased #

Patch Set 11 : rebased #

Total comments: 2

Patch Set 12 : Fix BiDi tests and indent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+314 lines, -227 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 3 4 5 6 7 8 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/first_run/first_run.cc View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/chrome_pages.cc View 1 2 3 4 5 6 7 3 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_impl.cc View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/sync/one_click_signin_helper.cc View 1 2 3 4 5 6 7 8 9 6 chunks +7 lines, -10 lines 0 comments Download
M chrome/browser/ui/sync/one_click_signin_helper_unittest.cc View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -4 lines 0 comments Download
chrome/browser/ui/webui/bidi_checker_web_ui_test.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/bidi_checker_web_ui_test.cc View 1 2 3 4 5 6 7 8 9 10 11 3 chunks +15 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/sync_promo/sync_promo_ui.h View 1 2 3 4 5 6 7 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/sync_promo/sync_promo_ui.cc View 1 2 3 4 5 6 7 2 chunks +10 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/sync_setup_handler.h View 1 2 3 4 5 6 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/sync_setup_handler.cc View 1 2 3 4 5 6 7 8 9 10 11 8 chunks +21 lines, -23 lines 0 comments Download
M chrome/browser/ui/webui/sync_setup_handler_unittest.cc View 1 2 3 4 5 6 7 31 chunks +232 lines, -164 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
Roger Tawa OOO till Jul 10th
Hi Tim, Drew, Please take a look. Thanks.
8 years ago (2012-12-03 14:53:13 UTC) #1
Andrew T Wilson (Slow)
lgtm
8 years ago (2012-12-03 15:02:20 UTC) #2
Roger Tawa OOO till Jul 10th
Hi Scott, Can you do an owner review please? I am changing a command line ...
8 years ago (2012-12-03 19:10:07 UTC) #3
sky
LGTM https://codereview.chromium.org/11316299/diff/10003/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/11316299/diff/10003/chrome/app/generated_resources.grd#newcode15252 chrome/app/generated_resources.grd:15252: + When enabled, will use a ClientLigin based ...
8 years ago (2012-12-03 22:00:48 UTC) #4
Roger Tawa OOO till Jul 10th
Hi Tim, I fixed the sync setup unit tests so that they are run with ...
8 years ago (2012-12-05 20:21:42 UTC) #5
tim (not reviewing)
Test approach LGTM!
8 years ago (2012-12-05 20:28:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerta@chromium.org/11316299/21001
8 years ago (2012-12-05 21:17:32 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
8 years ago (2012-12-05 23:06:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerta@chromium.org/11316299/21001
8 years ago (2012-12-05 23:43:46 UTC) #9
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
8 years ago (2012-12-06 00:18:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerta@chromium.org/11316299/33003
8 years ago (2012-12-06 01:39:16 UTC) #11
Andrew T Wilson (Slow)
https://codereview.chromium.org/11316299/diff/42001/chrome/browser/ui/webui/sync_setup_handler.cc File chrome/browser/ui/webui/sync_setup_handler.cc (right): https://codereview.chromium.org/11316299/diff/42001/chrome/browser/ui/webui/sync_setup_handler.cc#newcode1131 chrome/browser/ui/webui/sync_setup_handler.cc:1131: BringTabToFront(active_gaia_signin_tab_); Wrong indent.
8 years ago (2012-12-08 08:38:24 UTC) #12
Roger Tawa OOO till Jul 10th
Thanks Drew. https://codereview.chromium.org/11316299/diff/42001/chrome/browser/ui/webui/sync_setup_handler.cc File chrome/browser/ui/webui/sync_setup_handler.cc (right): https://codereview.chromium.org/11316299/diff/42001/chrome/browser/ui/webui/sync_setup_handler.cc#newcode1131 chrome/browser/ui/webui/sync_setup_handler.cc:1131: BringTabToFront(active_gaia_signin_tab_); On 2012/12/08 08:38:24, Andrew T Wilson ...
8 years ago (2012-12-08 14:42:16 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerta@chromium.org/11316299/49004
8 years ago (2012-12-08 15:41:31 UTC) #14
commit-bot: I haz the power
8 years ago (2012-12-08 18:26:54 UTC) #15
Message was sent while issue was closed. 
Change committed as 171983

Powered by Google App Engine
This is Rietveld 408576698