Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5172)

Unified Diff: chrome/browser/ui/webui/bidi_checker_web_ui_test.cc

Issue 11316299: Enable web-based sign in flow by default. Can use command line argument (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix BiDi tests and indent Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/bidi_checker_web_ui_test.cc
diff --git a/chrome/browser/ui/webui/bidi_checker_web_ui_test.cc b/chrome/browser/ui/webui/bidi_checker_web_ui_test.cc
index e40e838f57ab6806dc2fa77d13fc9060ce0ce59a..17d35d9cca166f0fcc9c9dcc70fdd647b0815da8 100644
--- a/chrome/browser/ui/webui/bidi_checker_web_ui_test.cc
+++ b/chrome/browser/ui/webui/bidi_checker_web_ui_test.cc
@@ -5,6 +5,7 @@
#include "chrome/browser/ui/webui/bidi_checker_web_ui_test.h"
#include "base/base_paths.h"
+#include "base/command_line.h"
#include "base/i18n/rtl.h"
#include "base/message_loop.h"
#include "base/path_service.h"
@@ -23,6 +24,7 @@
#include "chrome/browser/prefs/session_startup_pref.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser.h"
+#include "chrome/common/chrome_switches.h"
#include "chrome/common/url_constants.h"
#include "chrome/test/base/ui_test_utils.h"
#include "content/public/browser/browser_thread.h"
@@ -81,6 +83,19 @@ static const FilePath::CharType* kBidiCheckerTestsJS =
WebUIBidiCheckerBrowserTest::~WebUIBidiCheckerBrowserTest() {}
+void WebUIBidiCheckerBrowserTest::SetUp() {
+ // The new web-based sign in flow does not use webui. However, the old
+ // /CliengLogin flow does. Force this test to always run the old flow to make
+ // sure it does not regress.
+ if (!CommandLine::ForCurrentProcess()->HasSwitch(
+ switches::kUseClientLoginSigninFlow)) {
+ CommandLine::ForCurrentProcess()->AppendSwitch(
+ switches::kUseClientLoginSigninFlow);
+ }
+
+ WebUIBrowserTest::SetUp();
+}
+
WebUIBidiCheckerBrowserTest::WebUIBidiCheckerBrowserTest() {}
void WebUIBidiCheckerBrowserTest::SetUpInProcessBrowserTestFixture() {
« no previous file with comments | « chrome/browser/ui/webui/bidi_checker_web_ui_test.h ('k') | chrome/browser/ui/webui/sync_promo/sync_promo_ui.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698