Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Issue 11316141: Omnibox: Don't Force Notify Default Match Changed When Expiring Old Matches (Closed)

Created:
8 years, 1 month ago by Mark P
Modified:
8 years, 1 month ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, James Su
Visibility:
Public.

Description

Omnibox: Don't Force Notify Default Match Changed When Expiring Old Matches Previously, we force the autocomplete controller to notify the edit model that the edit default match has changed when we expire old matches, even if the default match didn't change. This removes that forcing code. I tested it on Linux for a bit. Everything looks fine to me. I didn't see any jankiness. Let's hope the other platforms are the same. BUG= TEST=by hand playing with the omnibox on Linux for five minutes Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=169180

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M chrome/browser/autocomplete/autocomplete_controller.cc View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mark P
As requested; seems to work. --mark
8 years, 1 month ago (2012-11-21 21:08:46 UTC) #1
Peter Kasting
LGTM
8 years, 1 month ago (2012-11-21 21:39:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpearson@chromium.org/11316141/1
8 years, 1 month ago (2012-11-21 21:40:48 UTC) #3
commit-bot: I haz the power
8 years, 1 month ago (2012-11-22 01:01:35 UTC) #4
Change committed as 169180

Powered by Google App Engine
This is Rietveld 408576698