Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Unified Diff: chrome/browser/autocomplete/autocomplete_controller.cc

Issue 11316141: Omnibox: Don't Force Notify Default Match Changed When Expiring Old Matches (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autocomplete/autocomplete_controller.cc
diff --git a/chrome/browser/autocomplete/autocomplete_controller.cc b/chrome/browser/autocomplete/autocomplete_controller.cc
index e7453814185ce8d8faa320072d3444253a70b210..26f53903625f58c2084dcd171b5e44a9d4f4a4a2 100644
--- a/chrome/browser/autocomplete/autocomplete_controller.cc
+++ b/chrome/browser/autocomplete/autocomplete_controller.cc
@@ -279,12 +279,7 @@ void AutocompleteController::ExpireCopiedEntries() {
// The first true makes UpdateResult() clear out the results and
// regenerate them, thus ensuring that no results from the previous
// result set remain.
- // The second true says to pretend the default match changed (even
- // if it did not). This may not be necessary but the code has been
- // like this for a long time and there's probably no great benefit in
- // changing it. Classically we have erred on the side of notifying
- // too often because it hasn't had any major side effects.
- UpdateResult(true, true);
+ UpdateResult(true, false);
}
void AutocompleteController::OnProviderUpdate(bool updated_matches) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698