Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1459)

Unified Diff: chrome/browser/sync/profile_sync_service_harness.cc

Issue 11314008: sync: Follow-up to conflict resolution refactor (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix tests Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/about_sync_util.cc ('k') | sync/engine/all_status.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/profile_sync_service_harness.cc
diff --git a/chrome/browser/sync/profile_sync_service_harness.cc b/chrome/browser/sync/profile_sync_service_harness.cc
index 58d31db0b99c7e7e473d9db0dcb693282fd40f89..59e01a262847425b4c96d3f68c890f9a88dbe1db 100644
--- a/chrome/browser/sync/profile_sync_service_harness.cc
+++ b/chrome/browser/sync/profile_sync_service_harness.cc
@@ -763,11 +763,9 @@ ProfileSyncService::Status ProfileSyncServiceHarness::GetStatus() {
// while ensuring that all conditions are evaluated using on the same snapshot.
bool ProfileSyncServiceHarness::IsDataSyncedImpl(
const SyncSessionSnapshot& snap) {
- return snap.num_simple_conflicts() == 0 &&
- ServiceIsPushingChanges() &&
+ return ServiceIsPushingChanges() &&
GetStatus().notifications_enabled &&
!service()->HasUnsyncedItems() &&
- !snap.has_more_to_sync() &&
!HasPendingBackendMigration();
}
@@ -999,9 +997,7 @@ std::string ProfileSyncServiceHarness::GetClientInfoString(
const SyncSessionSnapshot& snap = GetLastSessionSnapshot();
const ProfileSyncService::Status& status = GetStatus();
// Capture select info from the sync session snapshot and syncer status.
- os << "has_more_to_sync: "
- << snap.has_more_to_sync()
- << ", has_unsynced_items: "
+ os << ", has_unsynced_items: "
<< (service()->sync_initialized() ? service()->HasUnsyncedItems() : 0)
<< ", did_commit: "
<< (snap.model_neutral_state().num_successful_commits == 0 &&
@@ -1010,8 +1006,6 @@ std::string ProfileSyncServiceHarness::GetClientInfoString(
<< snap.num_encryption_conflicts()
<< ", hierarchy conflicts: "
<< snap.num_hierarchy_conflicts()
- << ", simple conflicts: "
- << snap.num_simple_conflicts()
<< ", server conflicts: "
<< snap.num_server_conflicts()
<< ", num_updates_downloaded : "
« no previous file with comments | « chrome/browser/sync/about_sync_util.cc ('k') | sync/engine/all_status.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698