Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: sync/engine/all_status.cc

Issue 11314008: sync: Follow-up to conflict resolution refactor (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix tests Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/profile_sync_service_harness.cc ('k') | sync/engine/nudge_source.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/engine/all_status.cc
diff --git a/sync/engine/all_status.cc b/sync/engine/all_status.cc
index 82457e466ee3fd07b0a96b4b307d4faf5412246d..9f5de500fa97d7fc61ae51fcece932609a04e084 100644
--- a/sync/engine/all_status.cc
+++ b/sync/engine/all_status.cc
@@ -10,7 +10,6 @@
#include "base/port.h"
#include "sync/engine/net/server_connection_manager.h"
#include "sync/internal_api/public/base/model_type.h"
-#include "sync/sessions/session_state.h"
namespace syncer {
@@ -31,7 +30,6 @@ SyncStatus AllStatus::CreateBlankStatus() const {
SyncStatus status = status_;
status.encryption_conflicts = 0;
status.hierarchy_conflicts = 0;
- status.simple_conflicts = 0;
status.server_conflicts = 0;
status.committed_count = 0;
status.initial_sync_ended = false;
@@ -44,7 +42,6 @@ SyncStatus AllStatus::CalcSyncing(const SyncEngineEvent &event) const {
const sessions::SyncSessionSnapshot& snapshot = event.snapshot;
status.encryption_conflicts = snapshot.num_encryption_conflicts();
status.hierarchy_conflicts = snapshot.num_hierarchy_conflicts();
- status.simple_conflicts = snapshot.num_simple_conflicts();
status.server_conflicts = snapshot.num_server_conflicts();
status.committed_count =
snapshot.model_neutral_state().num_successful_commits;
@@ -62,8 +59,6 @@ SyncStatus AllStatus::CalcSyncing(const SyncEngineEvent &event) const {
snapshot.model_neutral_state().sync_protocol_error;
// Accumulate update count only once per session to avoid double-counting.
- // TODO(ncarter): Make this realtime by having the syncer_status
- // counter preserve its value across sessions. http://crbug.com/26339
if (event.what_happened == SyncEngineEvent::SYNC_CYCLE_ENDED) {
status.updates_received +=
snapshot.model_neutral_state().num_updates_downloaded_total;
@@ -186,9 +181,6 @@ void AllStatus::IncrementNudgeCounter(NudgeSource source) {
case NUDGE_SOURCE_NOTIFICATION:
status_.nudge_source_notification++;
return;
- case NUDGE_SOURCE_CONTINUATION:
- status_.nudge_source_continuation++;
- return;
case NUDGE_SOURCE_UNKNOWN:
break;
}
« no previous file with comments | « chrome/browser/sync/profile_sync_service_harness.cc ('k') | sync/engine/nudge_source.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698