Issue 11314005: Remove unused JSReceiver::SetElement method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11314005: Remove unused JSReceiver::SetElement method (Closed)

Created:
8 years, 1 month ago by adamk

Modified:
8 years, 1 month ago

Reviewers:
rossberg

CC:
v8-dev, rafaelw

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Remove unused JSReceiver::SetElement method This method seems to have been created to handle dispatching SetElement appropriately to either JSProxy or JSObject, but it doesn't seem to ever be called. Once gone, JSProxy::SetElementWithHandler is also no longer called (we instead always call JSProxy::SetProperty to set both string and indexed properties). R=rossberg@chromium.org

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -39 lines)			Patch
	M	src/objects.h	View		2 chunks	+0 lines, -13 lines	0 comments	Download
	M	src/objects.cc	View		2 chunks	+0 lines, -26 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

rossberg

8 years, 1 month ago (2012-10-26 14:07:36 UTC) #2

As discussed offline, this method was added in anticipation of (yet
non-existent) changes and extensions to the V8 API wrt proxies.

Expand Messages | Collapse Messages