Chromium Code Reviews
Help | Chromium Project | Sign in
(19)

Issue 11314005: Remove unused JSReceiver::SetElement method (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 7 months ago by adamk
Modified:
2 years, 7 months ago
Reviewers:
rossberg
CC:
v8-dev, rafaelw
Visibility:
Public.

Description

Remove unused JSReceiver::SetElement method This method seems to have been created to handle dispatching SetElement appropriately to either JSProxy or JSObject, but it doesn't seem to ever be called. Once gone, JSProxy::SetElementWithHandler is also no longer called (we instead always call JSProxy::SetProperty to set both string and indexed properties). R=rossberg@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -39 lines) Patch
M src/objects.h View 2 chunks +0 lines, -13 lines 0 comments Download
M src/objects.cc View 2 chunks +0 lines, -26 lines 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 2 (0 generated)
adamk
2 years, 7 months ago (2012-10-26 13:11:11 UTC) #1
rossberg
2 years, 7 months ago (2012-10-26 14:07:36 UTC) #2
As discussed offline, this method was added in anticipation of (yet
non-existent) changes and extensions to the V8 API wrt proxies.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ec887be