Chromium Code Reviews
Help | Chromium Project | Sign in
(969)

Issue 11313014: Remove base/metrics/* code from NaCl IPC proxy build. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by bbudge
Modified:
1 year, 5 months ago
Reviewers:
jar
CC:
chromium-reviews_chromium.org, erikwright+watch_chromium.org, sadrul
Visibility:
Public.

Description

Remove base/metrics/* code from NaCl IPC proxy build.
This makes the IPC IRT nexes quite a bit smaller.
BUG=116317
TEST=compiles

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=164566

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Lint Patch
M base/base.gypi View 1 1 chunk +2 lines, -0 lines 0 comments 0 errors Download
M base/message_loop.cc View 1 2 chunks +4 lines, -0 lines 0 comments 0 errors Download
Commit:

Messages

Total messages: 6
bbudge
Trying to relieve Brett's review load. This CL removes unneeded code for the Chrome IPC ...
1 year, 5 months ago #1
jar
lgtm
1 year, 5 months ago #2
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bbudge@chromium.org/11313014/5001
1 year, 5 months ago #3
I haz the power (commit-bot)
Retried try job too often for step(s) chrome_frame_net_tests, sync_integration_tests
1 year, 5 months ago #4
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bbudge@chromium.org/11313014/5001
1 year, 5 months ago #5
I haz the power (commit-bot)
1 year, 5 months ago #6
Change committed as 164566
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6