Issue 11312167: [dart2dart] Triage co19 test failures.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11312167: [dart2dart] Triage co19 test failures. (Closed)

Created:
8 years, 1 month ago by Roman

Modified:
8 years, 1 month ago

Reviewers:
Anton Muhin

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

[dart2dart] Triage co19 test failures. Committed: https://code.google.com/p/dart/source/detail?r=14742

Patch Set 2 : #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+176 lines, -193 lines)			Patch
	M	tests/co19/co19-dart2dart.status	View	1	14 chunks	+176 lines, -193 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

lgtm and thanks a lot https://codereview.chromium.org/11312167/diff/1/tests/co19/co19-dart2dart.status File tests/co19/co19-dart2dart.status (right): https://codereview.chromium.org/11312167/diff/1/tests/co19/co19-dart2dart.status#newcode23 tests/co19/co19-dart2dart.status:23: # Partially implemented redirecting ...

8 years, 1 month ago (2012-11-09 13:53:52 UTC) #2

Roman

8 years, 1 month ago (2012-11-09 14:01:07 UTC) #3

https://chromiumcodereview.appspot.com/11312167/diff/1/tests/co19/co19-dart2d...
File tests/co19/co19-dart2dart.status (right):

https://chromiumcodereview.appspot.com/11312167/diff/1/tests/co19/co19-dart2d...
tests/co19/co19-dart2dart.status:23: # Partially implemented redirecting
constructors makes this fail.
On 2012/11/09 13:53:52, Anton Muhin wrote:
> bug number?

The test is actually negative, should result in compile-time error, inherited
from dart2js.

Expand Messages | Collapse Messages

Issue 11312167: [dart2dart] Triage co19 test failures. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages