Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1339)

Unified Diff: chrome/browser/extensions/platform_app_browsertest.cc

Issue 11312161: Disable ShellWindowRestorePosition due to flakiness. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/platform_app_browsertest.cc
diff --git a/chrome/browser/extensions/platform_app_browsertest.cc b/chrome/browser/extensions/platform_app_browsertest.cc
index 4e1037177cb22a26ca938b13e560b6ed51769655..da04fa9f134146e2638fc6b5ced568b4dbda4be2 100644
--- a/chrome/browser/extensions/platform_app_browsertest.cc
+++ b/chrome/browser/extensions/platform_app_browsertest.cc
@@ -607,9 +607,14 @@ IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, MutationEventsDisabled) {
// Test that windows created with an id will remember and restore their
// geometry when opening new windows.
-// Flaky, see http://crbug.com/155459.
+// Disabled due to flakiness on linux, see http://crbug.com/155459.
+#if defined(OS_LINUX) || defined(OS_CHROMEOS)
+#define MAYBE_ShellWindowRestorePosition DISABLED_ShellWindowRestorePosition
+#else
+#define MAYBE_ShellWindowRestorePosition FLAKY_ShellWindowRestorePosition
+#endif
IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest,
- FLAKY_ShellWindowRestorePosition) {
+ MAYBE_ShellWindowRestorePosition) {
ExtensionTestMessageListener page2_listener("WaitForPage2", true);
ExtensionTestMessageListener page3_listener("WaitForPage3", true);
ExtensionTestMessageListener done_listener("Done1", false);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698