Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Side by Side Diff: chrome/browser/extensions/platform_app_browsertest.cc

Issue 11312161: Disable ShellWindowRestorePosition due to flakiness. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/bind.h" 5 #include "base/bind.h"
6 #include "base/test/test_timeouts.h" 6 #include "base/test/test_timeouts.h"
7 #include "base/threading/platform_thread.h" 7 #include "base/threading/platform_thread.h"
8 #include "base/utf_string_conversions.h" 8 #include "base/utf_string_conversions.h"
9 #include "chrome/app/chrome_command_ids.h" 9 #include "chrome/app/chrome_command_ids.h"
10 #include "chrome/browser/automation/automation_util.h" 10 #include "chrome/browser/automation/automation_util.h"
(...skipping 589 matching lines...) Expand 10 before | Expand all | Expand 10 after
600 observer.Wait(); 600 observer.Wait();
601 ASSERT_EQ(2, browser()->tab_count()); 601 ASSERT_EQ(2, browser()->tab_count());
602 } 602 }
603 603
604 IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, MutationEventsDisabled) { 604 IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, MutationEventsDisabled) {
605 ASSERT_TRUE(RunPlatformAppTest("platform_apps/mutation_events")) << message_; 605 ASSERT_TRUE(RunPlatformAppTest("platform_apps/mutation_events")) << message_;
606 } 606 }
607 607
608 // Test that windows created with an id will remember and restore their 608 // Test that windows created with an id will remember and restore their
609 // geometry when opening new windows. 609 // geometry when opening new windows.
610 // Flaky, see http://crbug.com/155459. 610 // Disabled due to flakiness on linux, see http://crbug.com/155459.
611 #if defined(OS_LINUX) || defined(OS_CHROMEOS)
612 #define MAYBE_ShellWindowRestorePosition DISABLED_ShellWindowRestorePosition
613 #else
614 #define MAYBE_ShellWindowRestorePosition FLAKY_ShellWindowRestorePosition
615 #endif
611 IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, 616 IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest,
612 FLAKY_ShellWindowRestorePosition) { 617 MAYBE_ShellWindowRestorePosition) {
613 ExtensionTestMessageListener page2_listener("WaitForPage2", true); 618 ExtensionTestMessageListener page2_listener("WaitForPage2", true);
614 ExtensionTestMessageListener page3_listener("WaitForPage3", true); 619 ExtensionTestMessageListener page3_listener("WaitForPage3", true);
615 ExtensionTestMessageListener done_listener("Done1", false); 620 ExtensionTestMessageListener done_listener("Done1", false);
616 ExtensionTestMessageListener done2_listener("Done2", false); 621 ExtensionTestMessageListener done2_listener("Done2", false);
617 ExtensionTestMessageListener done3_listener("Done3", false); 622 ExtensionTestMessageListener done3_listener("Done3", false);
618 623
619 ASSERT_TRUE(LoadAndLaunchPlatformApp("geometry")); 624 ASSERT_TRUE(LoadAndLaunchPlatformApp("geometry"));
620 625
621 // Wait for the app to be launched (although this is mostly to have a 626 // Wait for the app to be launched (although this is mostly to have a
622 // message to reply to to let the script know it should create its second 627 // message to reply to to let the script know it should create its second
(...skipping 192 matching lines...) Expand 10 before | Expand all | Expand 10 after
815 ASSERT_TRUE(GetFirstShellWindow()); 820 ASSERT_TRUE(GetFirstShellWindow());
816 821
817 // Now tell the app to reload itself 822 // Now tell the app to reload itself
818 ExtensionTestMessageListener launched_listener2("Launched", false); 823 ExtensionTestMessageListener launched_listener2("Launched", false);
819 launched_listener.Reply("reload"); 824 launched_listener.Reply("reload");
820 ASSERT_TRUE(launched_listener2.WaitUntilSatisfied()); 825 ASSERT_TRUE(launched_listener2.WaitUntilSatisfied());
821 ASSERT_TRUE(GetFirstShellWindow()); 826 ASSERT_TRUE(GetFirstShellWindow());
822 } 827 }
823 828
824 } // namespace extensions 829 } // namespace extensions
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698