Teach the WebKit bots how to run layout tests, TestWebKitAPI and webkit_unit_tests for Android

Teach the WebKit bots how to run layout tests, TestWebKitAPI and webkit_unit_tests for Android

This will enable them to run the suites themselves. Having more detailed error
messages and uploading the created results will be implemented after this.

BUG=136774
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166417

[Isaac (away), 2012-11-06 19:01:26]

looks good w/ some suggestions

https://chromiumcodereview.appspot.com/11312101/diff/1/build/android/buildbot...
File build/android/buildbot/buildbot_functions.sh (right):

https://chromiumcodereview.appspot.com/11312101/diff/1/build/android/buildbot...
build/android/buildbot/buildbot_functions.sh:235: $(bb_get_json_prop
"$FACTORY_PROPERTIES" test_results_server)
nit, wrap this in double quotes for safety.  The following bash is valid, odd as
it may seem:

A="$(some "bash op")"

https://chromiumcodereview.appspot.com/11312101/diff/1/build/android/buildbot...
build/android/buildbot/buildbot_functions.sh:255: echo "@@@STEP_FAILURE@@@"
This code is unreachable.  The step is run under 'set -e' mode, so if python
returns non-zero exit status the script will early terminate.  Instead, you
should use bb_run_step.

bb_run_step python webkit/tools/layout... \
 ....
 ....

[Peter Beverloo, 2012-11-06 19:15:03]

Thank you for the comments.

https://chromiumcodereview.appspot.com/11312101/diff/1/build/android/buildbot...
File build/android/buildbot/buildbot_functions.sh (right):

https://chromiumcodereview.appspot.com/11312101/diff/1/build/android/buildbot...
build/android/buildbot/buildbot_functions.sh:235: $(bb_get_json_prop
"$FACTORY_PROPERTIES" test_results_server)
On 2012/11/06 19:01:27, Isaac wrote:
> nit, wrap this in double quotes for safety.  The following bash is valid, odd
as
> it may seem:
> 
> A="$(some "bash op")"

Done.

https://chromiumcodereview.appspot.com/11312101/diff/1/build/android/buildbot...
build/android/buildbot/buildbot_functions.sh:255: echo "@@@STEP_FAILURE@@@"
On 2012/11/06 19:01:27, Isaac wrote:
> This code is unreachable.  The step is run under 'set -e' mode, so if python
> returns non-zero exit status the script will early terminate.  Instead, you
> should use bb_run_step.
> 
> bb_run_step python webkit/tools/layout... \
>  ....
>  ....

Done.

[Isaac (away), 2012-11-06 19:22:26]

lgtm.  Is there a bug you can link?

[Peter Beverloo, 2012-11-07 11:06:00]

On 2012/11/06 19:22:26, Isaac wrote:
> lgtm.  Is there a bug you can link?

Updated. Thank you!

[commit-bot: I haz the power, 2012-11-07 11:06:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/peter@chromium.org/11312101/3001

[commit-bot: I haz the power, 2012-11-07 13:53:15]

Change committed as 166417