Teach the WebKit bots how to run layout tests, TestWebKitAPI and webkit_unit_tests for Android

build/android/buildbot/buildbot_functions.sh

 #!/bin/bash
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 #
 # Bash functions used by buildbot annotator scripts for the android
 # build of chromium.  Executing this script should not perform actions
 # other than setting variables and defining of functions.
 
 # Number of jobs on the compile line; e.g.  make -j"${JOBS}"
@@ skipping 190 matching lines @@
 function bb_print_logcat {
   echo "@@@BUILD_STEP Logcat dump@@@"
   python build/android/adb_logcat_printer.py "$LOGCAT_DUMP_DIR"
 }
 
 # Run tests on an actual device.  (Better have one plugged in!)
 function bb_run_unit_tests {
   build/android/run_tests.py --xvfb --verbose
 }
 
+# Run WebKit's test suites: webkit_unit_tests and TestWebKitAPI
+function bb_run_webkit_unit_tests {
+  build/android/run_tests.py --xvfb --verbose -s webkit_unit_tests
+  build/android/run_tests.py --xvfb --verbose -s TestWebKitAPI
+}
+
+# Lint WebKit's TestExpectation files.
+function bb_lint_webkit_expectation_files {
+  echo "@@@BUILD_STEP webkit_lint@@@"
+  python webkit/tools/layout_tests/run_webkit_tests.py \
+    --lint-test-files \
+    --chromium
+  if [[ $? -ne 0 ]]; then
+    echo "@@@STEP_FAILURE@@@"
+  fi
+}
+
+# Run layout tests on an actual device.
+function bb_run_webkit_layout_tests {
+  echo "@@@BUILD_STEP webkit_tests@@@"
+  local BUILDERNAME=$(bb_get_json_prop "$BUILD_PROPERTIES" buildername)
+  local BUILDNUMBER=$(bb_get_json_prop "$BUILD_PROPERTIES" buildnumber)
+  local MASTERNAME=$(bb_get_json_prop "$BUILD_PROPERTIES" mastername)
+  local RESULTSERVER=\
+      $(bb_get_json_prop "$FACTORY_PROPERTIES" test_results_server)

[Isaac (away), 2012/11/06 19:01:27]

nit, wrap this in double quotes for safety.  The following bash is valid, odd as
it may seem:

A="$(some "bash op")"

[Peter Beverloo, 2012/11/06 19:15:03]

Done.

+
+  python webkit/tools/layout_tests/run_webkit_tests.py \
+      --no-show-results \
+      --no-new-test-results \
+      --full-results-html \
+      --clobber-old-results \
+      --exit-after-n-failures 5000 \
+      --exit-after-n-crashes-or-timeouts 100 \
+      --debug-rwt-logging \
+      --results-directory "../layout-test-results" \
+      --target "$BUILDTYPE" \
+      --builder-name "$BUILDERNAME" \
+      --build-number "$BUILDNUMBER" \
+      --master-name "$MASTERNAME" \
+      --build-name "$BUILDERNAME" \
+      --platform=chromium-android \
+      --test-results-server "$RESULTSERVER"
+
+  if [[ $? -ne 0 ]]; then
+    echo "@@@STEP_FAILURE@@@"

[Isaac (away), 2012/11/06 19:01:27]

This code is unreachable.  The step is run under 'set -e' mode, so if python
returns non-zero exit status the script will early terminate.  Instead, you
should use bb_run_step.

bb_run_step python webkit/tools/layout... \
 ....
 ....

[Peter Beverloo, 2012/11/06 19:15:03]

Done.

+  fi
+}
+
 # Run experimental unittest bundles.
 function bb_run_experimental_unit_tests {
-# This build step was added because bash does not allow empty functions.
-# run_tests.py echoes a build step, comment/remove this build step when you
-# add tests to the experimental step.
-echo '@@@BUILD_STEP experimental_unit_tests@@@'
-
+  # This build step was added because bash does not allow empty functions.
+  # run_tests.py echoes a build step, comment/remove this build step when you
+  # add tests to the experimental step.
+  echo '@@@BUILD_STEP experimental_unit_tests@@@'
 }
 
 # Run findbugs.
 function bb_run_findbugs_diff {
   echo "@@@BUILD_STEP findbugs_diff@@@"
   build/android/findbugs_diff.py
 }
 
 # Run findbugs plugin tests.
 function bb_run_findbugs_plugin_tests {
@@ skipping 108 matching lines @@
   )
 }
 
 # Retrieve a packed json property using python
 function bb_get_json_prop {
   local JSON="$1"
   local PROP="$2"
 
   python -c "import json; print json.loads('$JSON').get('$PROP', '')"
 }