Omnibox: When backspacing out of keyword mode, don't highlight anything.

Omnibox: When backspacing out of keyword mode, don't highlight anything.

This bug was caused because Mac's NSMakeRange takes a beginning and a length.  All the other platform's range representations take a beginning and an end.

I audited omnibox_view_win.cc, omnibox_view_views.cc, and omnibox_view_gtk.cc.  They all seem to be correct.  I also tested Windows and Linux and verified that the current behavior is correct.

BUG=163807
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170929

[Mark P, 2012-12-03 21:11:30]

Peter,

Can you suggest an OWNER for this review?  I can't find any relevant OWNERS
file.

thanks,
mark

[Peter Kasting, 2012-12-03 22:56:30]

Mac omnibox implementation changes should go to shess.

[Mark P, 2012-12-03 22:57:57]

Hi Scott,

Can you please do this simple review at your leisure?

thanks,
mark

[Scott Hess - ex-Googler, 2012-12-03 23:07:47]

OH, ick.   LGTM.

[commit-bot: I haz the power, 2012-12-03 23:09:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mpearson@chromium.org/11308330/2001

[commit-bot: I haz the power, 2012-12-04 02:50:01]

Retried try job too often on mac_rel for step(s) browser_tests

[commit-bot: I haz the power, 2012-12-04 03:54:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mpearson@chromium.org/11308330/2001

[commit-bot: I haz the power, 2012-12-04 11:47:51]

Change committed as 170929