chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm - Issue 11308330: Omnibox: When backspacing out of keyword mode, don't highlight anything.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

Issue 11308330: Omnibox: When backspacing out of keyword mode, don't highlight anything. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: re-upload Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

diff --git a/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm b/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

index 0fbb6b09986d373c76c1d7415e8de0cbbd7f404a..9cf11b3f41490ce298b3dacf4a8e176c57306391 100644

--- a/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

+++ b/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

@@ -269,7 +269,7 @@ void OmniboxViewMac::SetWindowTextAndCaretPos(const string16& text,

bool update_popup,

bool notify_text_changed) {

DCHECK_LE(caret_pos, text.size());

- SetTextAndSelectedRange(text, NSMakeRange(caret_pos, caret_pos));

+ SetTextAndSelectedRange(text, NSMakeRange(caret_pos, 0));

if (update_popup)

UpdatePopup();

« no previous file with comments | « no previous file | no next file » | no next file with comments »