Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: chrome/browser/ui/browser_command_controller_unittest.cc

Issue 11308085: Enable fullscreen for apps windows (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address comment Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/browser_command_controller.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser_command_controller_unittest.cc
diff --git a/chrome/browser/ui/browser_command_controller_unittest.cc b/chrome/browser/ui/browser_command_controller_unittest.cc
index 54b0b377f33e91f833606bcd5ada04abecca5fb1..4e66090f9e67a36639df655e53724b0ef4dd625f 100644
--- a/chrome/browser/ui/browser_command_controller_unittest.cc
+++ b/chrome/browser/ui/browser_command_controller_unittest.cc
@@ -6,6 +6,7 @@
#include "chrome/app/chrome_command_ids.h"
#include "chrome/browser/ui/browser.h"
+#include "chrome/browser/ui/browser_commands.h"
#include "chrome/browser/ui/browser_window_state.h"
#include "chrome/test/base/browser_with_test_window_test.h"
#include "content/public/browser/native_web_keyboard_event.h"
@@ -117,3 +118,28 @@ TEST_F(BrowserWithTestWindowTest, IsReservedCommandOrKeyIsApp) {
ui::ET_KEY_PRESSED, false, ui::VKEY_F, ui::EF_CONTROL_DOWN, 0)));
#endif // USE_AURA
}
+
+TEST_F(BrowserWithTestWindowTest, AppFullScreen) {
+ // Enable for tabbed browser.
+ EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_FULLSCREEN));
+
+ // Enabled for app windows.
+ browser()->app_name_ = "app";
+ ASSERT_TRUE(browser()->is_app());
+ browser()->command_controller()->FullscreenStateChanged();
+ EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_FULLSCREEN));
+
+ // Enabled for panels.
+ Browser::CreateParams panel_params(Browser::TYPE_PANEL, profile());
+ TestBrowserWindow panel_window;
+ panel_params.window = &panel_window;
+ Browser panel_browser(panel_params);
+ ASSERT_TRUE(panel_browser.is_type_panel());
+ EXPECT_TRUE(chrome::IsCommandEnabled(&panel_browser, IDC_FULLSCREEN));
+
+ // Disabled for app-panels.
+ panel_browser.app_name_ = "app";
+ ASSERT_TRUE(panel_browser.is_app());
+ panel_browser.command_controller()->FullscreenStateChanged();
+ EXPECT_FALSE(chrome::IsCommandEnabled(&panel_browser, IDC_FULLSCREEN));
+}
« no previous file with comments | « chrome/browser/ui/browser_command_controller.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698