chrome/browser/ui/browser_command_controller.cc - Issue 11308085: Enable fullscreen for apps windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_command_controller.cc

Issue 11308085: Enable fullscreen for apps windows (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: address comment Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/browser_command_controller.cc

diff --git a/chrome/browser/ui/browser_command_controller.cc b/chrome/browser/ui/browser_command_controller.cc

index 93df2cdf7da9b80951e4e48a80041ff9a41a86b1..1d7cb5c7dd27feccb5600af4e5a442be2a5cee48 100644

--- a/chrome/browser/ui/browser_command_controller.cc

+++ b/chrome/browser/ui/browser_command_controller.cc

@@ -1100,10 +1100,11 @@ void BrowserCommandController::UpdateCommandsForFullscreenMode(

command_updater_.UpdateCommandEnabled(IDC_PROFILING_ENABLED, show_main_ui);

#endif

- // Disable explicit fullscreen toggling when in metro snap mode.

- bool fullscreen_enabled = !browser_->is_type_panel() &&

- !browser_->is_app() &&

- fullscreen_mode != FULLSCREEN_METRO_SNAP;

+ // Disable explicit fullscreen toggling for app-panels and when in metro snap

+ // mode.

+ bool fullscreen_enabled =

+ !(browser_->is_type_panel() && browser_->is_app()) &&

+ fullscreen_mode != FULLSCREEN_METRO_SNAP;

#if defined(OS_MACOSX)

// The Mac implementation doesn't support switching to fullscreen while

// a tab modal dialog is displayed.