Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 11308032: - Make sure to add predefined symbols into the current symbol table after growth. (Closed)

Created:
8 years, 1 month ago by Ivan Posva
Modified:
8 years, 1 month ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

- Make sure to add predefined symbols into the current symbol table after growth. Committed: https://code.google.com/p/dart/source/detail?r=14948

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M runtime/vm/symbols.cc View 2 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ivan Posva
8 years, 1 month ago (2012-11-15 08:59:17 UTC) #1
Mads Ager (google)
LGTM Can a test be added for this?
8 years, 1 month ago (2012-11-15 09:04:08 UTC) #2
Ivan Posva
On 2012/11/15 09:04:08, Mads Ager wrote: > LGTM > > Can a test be added ...
8 years, 1 month ago (2012-11-15 09:12:07 UTC) #3
siva
8 years, 1 month ago (2012-11-15 18:28:40 UTC) #4
Nice catch.

Powered by Google App Engine
This is Rietveld 408576698